Make test harness useable outside of Syzygy

Make test harness useable outside of Syzygy

This makes the inputs to the test harness configurable rather than hardcoded. This allows the test harness to be used from other project directories.
Committed: http://code.google.com/p/sawbuck/source/browse/#svn/trunk383

[chrisha, 2011-07-13 14:20:20]

PTAL

[Roger McFarlane, 2011-07-13 15:02:49]

http://codereview.appspot.com/4711043/diff/2001/syzygy/py/test_utils/gyp_test...
File syzygy/py/test_utils/gyp_tests.py (right):

http://codereview.appspot.com/4711043/diff/2001/syzygy/py/test_utils/gyp_test...
syzygy/py/test_utils/gyp_tests.py:58: if gyp_path:
this moves the call to the parent's constructor out of the child's constructor.
So, later calls to a new GypTests instance constructed with gyp_path=None are
made against an "uninitialized" python object.

Instead, make this constructor look for the gyp path in the arguments and always
create a valid instance, instead of deferring to Main().

[chrisha, 2011-07-13 15:32:52]

PTAnotherL

http://codereview.appspot.com/4711043/diff/2001/syzygy/py/test_utils/gyp_test...
File syzygy/py/test_utils/gyp_tests.py (right):

http://codereview.appspot.com/4711043/diff/2001/syzygy/py/test_utils/gyp_test...
syzygy/py/test_utils/gyp_tests.py:58: if gyp_path:
On 2011/07/13 15:02:49, Roger McFarlane wrote:
> this moves the call to the parent's constructor out of the child's
constructor.
> So, later calls to a new GypTests instance constructed with gyp_path=None are
> made against an "uninitialized" python object.
> 
> Instead, make this constructor look for the gyp path in the arguments and
always
> create a valid instance, instead of deferring to Main().

Done.

[Roger McFarlane, 2011-07-13 15:39:22]

lgtm with nits

http://codereview.appspot.com/4711043/diff/5001/syzygy/py/test_utils/gyp_test...
File syzygy/py/test_utils/gyp_tests.py (right):

http://codereview.appspot.com/4711043/diff/5001/syzygy/py/test_utils/gyp_test...
syzygy/py/test_utils/gyp_tests.py:64: options, args = parser.parse_args()
options, _args = ...

-- or --

options, unused_args = ...

-- or --

options = parser.parse_args()[0]

http://codereview.appspot.com/4711043/diff/5001/syzygy/py/test_utils/gyp_test...
syzygy/py/test_utils/gyp_tests.py:84: def _GetOptParser(self):
Can this be static (here and in the parent class?)

With a note that it's may be referenced from the constructor before the parent
class is fully constructed.

[chrisha, 2011-07-13 15:51:23]

Thanks, committing.

http://codereview.appspot.com/4711043/diff/5001/syzygy/py/test_utils/gyp_test...
File syzygy/py/test_utils/gyp_tests.py (right):

http://codereview.appspot.com/4711043/diff/5001/syzygy/py/test_utils/gyp_test...
syzygy/py/test_utils/gyp_tests.py:64: options, args = parser.parse_args()
On 2011/07/13 15:39:22, Roger McFarlane wrote:
> options, _args = ...
> 
> -- or --
> 
> options, unused_args = ...
> 
> -- or --
> 
> options = parser.parse_args()[0]

Done.

http://codereview.appspot.com/4711043/diff/5001/syzygy/py/test_utils/gyp_test...
syzygy/py/test_utils/gyp_tests.py:84: def _GetOptParser(self):
On 2011/07/13 15:39:22, Roger McFarlane wrote:
> Can this be static (here and in the parent class?)
> 
> With a note that it's may be referenced from the constructor before the parent
> class is fully constructed.

Done.