Issue 4700048: Fix GObject ref/unref issues.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4700048: Fix GObject ref/unref issues. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 11 months ago by Daiki Ueno

Modified:
12 years, 11 months ago

Reviewers:
shawn.p.huang, Peng

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

Description

Fix GObject ref/unref issues. BUG=none TEST=manual

Patch Set 1 #

Created: 12 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	bus/registry.c	View		2 chunks	+3 lines, -2 lines	0 comments	Download
	M	bus/test-client.c	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Daiki Ueno

As BusFactoryProxy and IBusInputContext are no longer derived from IBusObject, g_object_ref_sink is not needed after ...

12 years, 11 months ago (2011-07-14 02:54:23 UTC) #1

Peng

12 years, 11 months ago (2011-07-14 12:34:19 UTC) #2

On 2011/07/14 02:54:23, Daiki Ueno wrote:
> As BusFactoryProxy and IBusInputContext are no longer derived from IBusObject,
> g_object_ref_sink is not needed after creation.
> 
> Adding ref_sink to buscomp in bus_registry_load_in_dir is for consistency with
> bus_registry_load_cache.
> 
> BTW, I created systemtap probes to check IBusProxy refs.  The log looks mostly
> good so far (after the patch is applied):
> 
> http://ueno.fedorapeople.org/ibus-stap/

LGTM. Please use git cl push to submit the CL. Thx

Expand All Messages | Collapse All Messages