Issue 4686047: Fix 1581: Only NoteEvents can cause a tie. Ignore all other events that create note heads

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4686047: Fix 1581: Only NoteEvents can cause a tie. Ignore all other events that create note heads (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 10 months ago by Reinhold

Modified:
12 years, 9 months ago

Reviewers:
pkx166h, Neil Puttock

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Fix 1581: Only NoteEvents can cause a tie. Ignore all other events that create note heads

Patch Set 1 #

Total comments: 1

Created: 12 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -0 lines)			Patch
	A	input/regression/tie-pitched-trill.ly	View		1 chunk	+12 lines, -0 lines	0 comments	Download
	M	lily/tie-engraver.cc	View		1 chunk	+5 lines, -0 lines	1 comment	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Neil Puttock

LGTM. http://codereview.appspot.com/4686047/diff/1/lily/tie-engraver.cc File lily/tie-engraver.cc (right): http://codereview.appspot.com/4686047/diff/1/lily/tie-engraver.cc#newcode275 lily/tie-engraver.cc:275: { remove braces

12 years, 10 months ago (2011-07-10 20:57:27 UTC) #1

Pass Make and reg tests - James

Expand All Messages | Collapse All Messages