Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5)

Issue 4685051: "make" script to enable command-line build on Windows (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 2 months ago by epoger
Modified:
13 years, 2 months ago
Reviewers:
bungeman
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

This make.py script (along with launching make.bat) will allow developers and buildbots to build on Windows just using the usual "make <target>" syntax. Note that Visual Studio fails to build using this mechanism. It is blocked by a gyp issue that I have created a workaround for in http://codereview.chromium.org/7210040/ ('Add --msvs-abspath-output flag to work around bug in msvs2010 project generation.')

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+169 lines, -0 lines) Patch
A make.bat View 1 chunk +38 lines, -0 lines 0 comments Download
A make.py View 1 chunk +131 lines, -0 lines 0 comments Download

Messages

Total messages: 3
epoger
13 years, 2 months ago (2011-07-11 19:26:16 UTC) #1
bungeman
On 2011/07/11 19:26:16, epoger wrote: LGTM
13 years, 2 months ago (2011-07-11 19:35:41 UTC) #2
epoger
13 years, 2 months ago (2011-07-11 19:53:00 UTC) #3
committed as r1838
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b