Fix 1676: Properly count the notes in a chord tremolo (ignore all non-note events)

Fix 1676: Properly count the notes in a chord tremolo (ignore all non-note events)

[Neil Puttock, 2011-07-10 21:29:47]

http://codereview.appspot.com/4685049/diff/1/input/regression/chord-tremolo-o...
File input/regression/chord-tremolo-other-commands.ly (right):

http://codereview.appspot.com/4685049/diff/1/input/regression/chord-tremolo-o...
input/regression/chord-tremolo-other-commands.ly:3: \header{
\header {

http://codereview.appspot.com/4685049/diff/1/input/regression/chord-tremolo-o...
input/regression/chord-tremolo-other-commands.ly:4: texidoc="
indent

texidoc = "

http://codereview.appspot.com/4685049/diff/1/scm/music-functions.scm
File scm/music-functions.scm (right):

http://codereview.appspot.com/4685049/diff/1/scm/music-functions.scm#newcode292
scm/music-functions.scm:292: (note-count (ly:music-property main 'elements))
(length (extract-named-music main 'EventChord))

[pkx166h, 2011-07-10 23:03:21]

This passes a make but fails a reg test check

--snip--
Processing 6b/lily-e3e71d48
Processing f3/lily-989d2907
Processing 56/lily-9940850d
Processing 7c/lily-568fad2b
error: Children (1) exited with errors.
command failed: /home/jlowe/lilypond-git/out/bin/lilypond -I ./ -I ./out-test -I
../../input -I /home/jlowe/lilypond-git/Documentation -I
/home/jlowe/lilypond-git/Documentation/snippets -I ../../input/regression/ -I
/home/jlowe/lilypond-git/Documentation/included/ -I
/home/jlowe/lilypond-git/mf/out/ -I /home/jlowe/lilypond-git/mf/out/ -I
/home/jlowe/lilypond-git/Documentation/pictures -I
/home/jlowe/lilypond-git/Documentation/pictures/./out-test -dbackend=eps
--formats=ps -djob-count=7 -dseparate-log-files -dinclude-eps-fonts
-dgs-load-lily-fonts --header=texidoc -I
/home/jlowe/lilypond-git/Documentation/included/ -ddump-profile
-dcheck-internal-types -ddump-signatures -danti-alias-factor=1 -I 
"/home/jlowe/lilypond-git/out/lybook-testdb"  -I 
"/home/jlowe/lilypond-git/input/regression"  -I 
"/home/jlowe/lilypond-git/input/regression"  -I 
"/home/jlowe/lilypond-git/input/regression/out-test"  -I 
"/home/jlowe/lilypond-git/input"  -I  "/home/jlowe/lilypond-git/Documentation" 
-I  "/home/jlowe/lilypond-git/Documentation/snippets"  -I 
"/home/jlowe/lilypond-git/input/regression"  -I 
"/home/jlowe/lilypond-git/Documentation/included"  -I 
"/home/jlowe/lilypond-git/mf/out"  -I  "/home/jlowe/lilypond-git/mf/out"  -I 
"/home/jlowe/lilypond-git/Documentation/pictures"  -I 
"/home/jlowe/lilypond-git/Documentation/pictures/out-test" --formats=eps 
-deps-box-padding=3.000000  -dread-file-list -dno-strip-output-dir 
"/home/jlowe/lilypond-git/out/lybook-testdb/snippet-names-1306104669.ly"
Child returned 1
make[2]: *** [out-test/collated-files.texi] Error 1
rm out-test/weblinks.itexi
make[2]: Leaving directory `/home/jlowe/lilypond-git/input/regression'
make[1]: *** [local-test] Error 2
make[1]: Leaving directory `/home/jlowe/lilypond-git/input/regression'
make: *** [test] Error 2
jlowe@jlowe-lilybuntu2:~/lilypond-git$ 
---snip--

When I look up

Processing 7c/lily-568fad2b
error: Children (1) exited with errors.

I get the reg test file containing:
\sourcefilename "repeat-tremolo-chord-rep.ly"

[Reinhold, 2011-07-11 11:44:19]

On 2011/07/10 23:03:21, J_lowe wrote:
> This passes a make but fails a reg test check

New patch uploaded that uses Neil's suggestions about extract-named-music. That
function also correctly works with repeated chords, so the crash also goes away
with the new patch.

Cheers,
Reinhold

[Neil Puttock, 2011-07-11 19:19:12]

http://codereview.appspot.com/4685049/diff/5001/scm/music-functions.scm
File scm/music-functions.scm (right):

http://codereview.appspot.com/4685049/diff/5001/scm/music-functions.scm#newco...
scm/music-functions.scm:249: (define (note-count music-elements)
remove

http://codereview.appspot.com/4685049/diff/5001/scm/music-functions.scm#newco...
scm/music-functions.scm:318: if durations in @var{music} vary, allowing slash
beats and double-percent
thank you :)

[pkx166h, 2011-07-11 21:09:17]

Passes Make and Reg tests. James