Issue 4684042: Changed two assertions to explicit tests, and added an error code to

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4684042: Changed two assertions to explicit tests, and added an error code to (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 11 months ago by kbr1

Modified:
12 years, 11 months ago

Reviewers:
dgkoch, nicolas

CC:
angleproject-review_googlegroups.com, apatrick1

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Changed two assertions to explicit tests, and added an error code to those checked during ReadPixels. These changes are needed to avoid having ANGLE assert in debug builds when running WebGL test cases which provoke a GPU reset. BUG=none TEST=slow-shader-example and lots-of-polys-example in WebGL test suite Committed: http://code.google.com/p/angleproject/source/detail?r=703

Patch Set 1 #

Created: 12 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -4 lines)			Patch
	M	src/libEGL/Display.cpp	View		2 chunks	+8 lines, -4 lines	0 comments	Download
	M	src/libGLESv2/Context.cpp	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

dgkoch

On 2011/07/08 17:48:21, dgkoch wrote: > you forgot to update version.h though.. fixed.

12 years, 11 months ago (2011-07-08 18:10:31 UTC) #4

kbr1

12 years, 11 months ago (2011-07-08 18:27:41 UTC) #5

On 2011/07/08 18:10:31, dgkoch wrote:
> On 2011/07/08 17:48:21, dgkoch wrote:
> > you forgot to update version.h though..
> 
> fixed.

Argh. Sorry and thanks for cleaning that up for me.

We really need a post-commit hook, or some other automatic versioning
solution...

Expand All Messages | Collapse All Messages