Issue 4678043: Reduce gets of ext string and check validity of stencil format enums

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4678043: Reduce gets of ext string and check validity of stencil format enums (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by bsalomon

Modified:
13 years, 4 months ago

Reviewers:
TomH, reed1

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+139 lines, -69 lines)			Patch
M	gpu/include/GrGLInterface.h	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	gpu/src/GrGLInterface.cpp	View	3 chunks	+25 lines, -1 line	0 comments	Download
M	gpu/src/GrGpuGL.h	View	5 chunks	+23 lines, -0 lines	0 comments	Download
M	gpu/src/GrGpuGL.cpp	View	17 chunks	+83 lines, -61 lines	0 comments	Download
M	gpu/src/GrGpuGLShaders.cpp	View	1 chunk	+3 lines, -5 lines	0 comments	Download
M	samplecode/SampleBitmapRect.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5

bsalomon

This fixes Marshall's complaint about asserts when trying stencil index 4. It also reduces the ...

13 years, 4 months ago (2011-07-06 16:06:47 UTC) #1

bsalomon

On Wed, Jul 6, 2011 at 12:17 PM, <tomhudson@google.com> wrote: > LGTM. > > Why ...

13 years, 4 months ago (2011-07-06 17:18:57 UTC) #3

Closed with r1801