Remove the callback on destroy.

Remove the callback on destroy.

BUG=crosbug.com/17293
TEST=src/tests/ibus-bus.c

[Peng Huang, 2011-07-10 14:55:24]

http://codereview.appspot.com/4675074/diff/1/src/ibusbus.c
File src/ibusbus.c (right):

http://codereview.appspot.com/4675074/diff/1/src/ibusbus.c#newcode403
src/ibusbus.c:403: bus);
_connection_closed_cb callback will releases some resources. If we disconnect
it, we need release them in this function.

[Yusuke Sato, 2011-07-10 15:48:03]

http://codereview.appspot.com/4675074/diff/1/src/ibusbus.c
File src/ibusbus.c (right):

http://codereview.appspot.com/4675074/diff/1/src/ibusbus.c#newcode403
src/ibusbus.c:403: bus);
On 2011/07/10 14:55:24, Peng Huang wrote:
> _connection_closed_cb callback will releases some resources. If we disconnect
> it, we need release them in this function.

True, but 'g_free (bus->priv->unique_name);' is already called in this function.
Which resources are you in mind?

[Peng Huang, 2011-07-10 16:30:41]

http://codereview.appspot.com/4675074/diff/1/src/ibusbus.c
File src/ibusbus.c (right):

http://codereview.appspot.com/4675074/diff/1/src/ibusbus.c#newcode403
src/ibusbus.c:403: bus);
On 2011/07/10 15:48:03, Yusuke Sato wrote:
> On 2011/07/10 14:55:24, Peng Huang wrote:
> > _connection_closed_cb callback will releases some resources. If we
disconnect
> > it, we need release them in this function.
> 
> True, but 'g_free (bus->priv->unique_name);' is already called in this
function.
> Which resources are you in mind?

I checked the callback.  I think we need release the GDBusConnection here at
least.

[Yusuke Sato, 2011-07-11 00:43:00]

thanks, fixed. please take another look.

On 2011/07/10 16:30:41, Peng Huang wrote:
> http://codereview.appspot.com/4675074/diff/1/src/ibusbus.c
> File src/ibusbus.c (right):
> 
> http://codereview.appspot.com/4675074/diff/1/src/ibusbus.c#newcode403
> src/ibusbus.c:403: bus);
> On 2011/07/10 15:48:03, Yusuke Sato wrote:
> > On 2011/07/10 14:55:24, Peng Huang wrote:
> > > _connection_closed_cb callback will releases some resources. If we
> disconnect
> > > it, we need release them in this function.
> > 
> > True, but 'g_free (bus->priv->unique_name);' is already called in this
> function.
> > Which resources are you in mind?
> 
> I checked the callback.  I think we need release the GDBusConnection here at
> least.

[Peng, 2011-07-11 02:22:12]

On 2011/07/11 00:43:00, Yusuke Sato wrote:
> thanks, fixed. please take another look.
> 
> On 2011/07/10 16:30:41, Peng Huang wrote:
> > http://codereview.appspot.com/4675074/diff/1/src/ibusbus.c
> > File src/ibusbus.c (right):
> > 
> > http://codereview.appspot.com/4675074/diff/1/src/ibusbus.c#newcode403
> > src/ibusbus.c:403: bus);
> > On 2011/07/10 15:48:03, Yusuke Sato wrote:
> > > On 2011/07/10 14:55:24, Peng Huang wrote:
> > > > _connection_closed_cb callback will releases some resources. If we
> > disconnect
> > > > it, we need release them in this function.
> > > 
> > > True, but 'g_free (bus->priv->unique_name);' is already called in this
> > function.
> > > Which resources are you in mind?
> > 
> > I checked the callback.  I think we need release the GDBusConnection here at
> > least.

LGTM