Expand array bounds checking to work with pointer arithmetic and unary & and *

[nlewycky1, 2011-07-09 00:13:39]

http://codereview.appspot.com/4675068/diff/1/include/clang/Basic/DiagnosticSe...
File include/clang/Basic/DiagnosticSemaKinds.td (right):

http://codereview.appspot.com/4675068/diff/1/include/clang/Basic/DiagnosticSe...
include/clang/Basic/DiagnosticSemaKinds.td:4009: "the pointer incremented by %0
refers past the end of the array (that contains %1 elements)">,
Please use "%plural{1:element|:elements}".

[Kaelyn, 2011-07-09 03:12:59]

Thanks. I'll also fix that for the existing array bounds message to keep
both consistent. :)

On Fri, Jul 8, 2011 at 5:13 PM, <nlewycky@google.com> wrote:

>
> http://codereview.appspot.com/**4675068/diff/1/include/clang/**
>
Basic/DiagnosticSemaKinds.td<http://codereview.appspot.com/4675068/diff/1/include/clang/Basic/DiagnosticSemaKinds.td>
> File include/clang/Basic/**DiagnosticSemaKinds.td (right):
>
> http://codereview.appspot.com/**4675068/diff/1/include/clang/**
>
Basic/DiagnosticSemaKinds.td#**newcode4009<http://codereview.appspot.com/4675068/diff/1/include/clang/Basic/DiagnosticSemaKinds.td#newcode4009>
> include/clang/Basic/**DiagnosticSemaKinds.td:4009: "the pointer
> incremented by %0 refers past the end of the array (that contains %1
> elements)">,
> Please use "%plural{1:element|:elements}"**.
>
>
http://codereview.appspot.com/**4675068/<http://codereview.appspot.com/4675068/>
>

[tkremenek, 2011-07-11 22:29:35]

On 2011/07/09 03:12:59, rikka wrote:
> Thanks. I'll also fix that for the existing array bounds message to keep
> both consistent. :)
> 
> On Fri, Jul 8, 2011 at 5:13 PM, <mailto:nlewycky@google.com> wrote:
> 
> >
> > http://codereview.appspot.com/**4675068/diff/1/include/clang/**
> >
>
Basic/DiagnosticSemaKinds.td<http://codereview.appspot.com/4675068/diff/1/include/clang/Basic/DiagnosticSemaKinds.td>
> > File include/clang/Basic/**DiagnosticSemaKinds.td (right):
> >
> > http://codereview.appspot.com/**4675068/diff/1/include/clang/**
> >
>
Basic/DiagnosticSemaKinds.td#**newcode4009<http://codereview.appspot.com/4675068/diff/1/include/clang/Basic/DiagnosticSemaKinds.td#newcode4009>
> > include/clang/Basic/**DiagnosticSemaKinds.td:4009: "the pointer
> > incremented by %0 refers past the end of the array (that contains %1
> > elements)">,
> > Please use "%plural{1:element|:elements}"**.
> >
> >
>
http://codereview.appspot.com/**4675068/%3Chttp://codereview.appspot.com/4675...>
> >

Great work.  This almost looks done.  If you push out the change using the
plural form, I think this is ready to go back to mainline.

[Kaelyn, 2011-07-11 22:52:43]

On Mon, Jul 11, 2011 at 3:29 PM, <tkremenek@gmail.com> wrote:

> On 2011/07/09 03:12:59, rikka wrote:
>
>> Thanks. I'll also fix that for the existing array bounds message to
>>
> keep
>
>> both consistent. :)
>>
>
>  On Fri, Jul 8, 2011 at 5:13 PM, <mailto:nlewycky@google.com> wrote:
>>
>
>  >
>> >
http://codereview.appspot.com/****4675068/diff/1/include/**clang/**<http://co...
>> >
>>
>
> Basic/DiagnosticSemaKinds.td<h**ttp://codereview.appspot.com/**
>
4675068/diff/1/include/clang/**Basic/DiagnosticSemaKinds.td<http://codereview.appspot.com/4675068/diff/1/include/clang/Basic/DiagnosticSemaKinds.td>
> >
>
>  > File include/clang/Basic/****DiagnosticSemaKinds.td (right):
>> >
>> >
http://codereview.appspot.com/****4675068/diff/1/include/**clang/**<http://co...
>> >
>>
>
> Basic/DiagnosticSemaKinds.td#****newcode4009<http://**
> codereview.appspot.com/**4675068/diff/1/include/clang/**
>
Basic/DiagnosticSemaKinds.td#**newcode4009<http://codereview.appspot.com/4675068/diff/1/include/clang/Basic/DiagnosticSemaKinds.td#newcode4009>
> >
>
>  > include/clang/Basic/****DiagnosticSemaKinds.td:4009: "the pointer
>> > incremented by %0 refers past the end of the array (that contains %1
>> > elements)">,
>> > Please use "%plural{1:element|:elements}"****.
>> >
>> >
>>
>
> http://codereview.appspot.com/****4675068/%3Chttp://**
>
codereview.appspot.com/**4675068/<http://codereview.appspot.com/**4675068/%3Chttp://codereview.appspot.com/4675068/>
> >
>
>> >
>>
>
> Great work.  This almost looks done.  If you push out the change using
> the plural form, I think this is ready to go back to mainline.


The change was added on the code review site, but I'll go ahead and send an
updated patch to cfe-commits for pushing to mainline. ;)

Thanks,
Kaelyn



>
>
>
http://codereview.appspot.com/**4675068/<http://codereview.appspot.com/4675068/>
>

[Kaelyn, 2011-08-05 23:21:19]

This patch was submitted as r136997 after resolving merge conflicts and adding a
few more comments above the new calls to CheckArrayAccess().