Issue 4675062: Fix div by zero in GPU degenerate radials (and add sample)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4675062: Fix div by zero in GPU degenerate radials (and add sample) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 6 months ago by bsalomon

Modified:
13 years, 6 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 2 : fix name, add gm baselines #

Created: 13 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+165 lines, -75 lines)			Patch
A	gm/base-linux/gradients_degenerate_2pt_4444.png	View	1	Binary file		0 comments	Download
A	gm/base-linux/gradients_degenerate_2pt_565.png	View	1	Binary file		0 comments	Download
A	gm/base-linux/gradients_degenerate_2pt_8888.png	View	1	Binary file		0 comments	Download
A	gm/base-linux/gradients_degenerate_2pt_gpu.png	View	1	Binary file		0 comments	Download
M	gpu/include/GrSamplerState.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	gpu/src/GrGLProgram.h	View	1	2 chunks	+6 lines, -1 line	0 comments	Download
M	gpu/src/GrGLProgram.cpp	View	1	11 chunks	+49 lines, -17 lines	0 comments	Download
M	gpu/src/GrGpuGLShaders.cpp	View	1	5 chunks	+20 lines, -8 lines	0 comments	Download
M	gyp/SampleApp.gyp	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
A	samplecode/SampleDegenerateTwoPtRadials.cpp	View	1	1 chunk	+85 lines, -0 lines	0 comments	Download
M	samplecode/SampleXfermodesBlur.cpp	View	1	3 chunks	+1 line, -49 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bsalomon

Still work to do around near-degenerate (for both SW and GPU)

13 years, 6 months ago (2011-07-07 14:11:54 UTC) #1

reed1

LGTM w/ possible name change http://codereview.appspot.com/4675062/diff/1/gpu/include/GrSamplerState.h File gpu/include/GrSamplerState.h (right): http://codereview.appspot.com/4675062/diff/1/gpu/include/GrSamplerState.h#newcode207 gpu/include/GrSamplerState.h:207: // equation. bool radial2IsDegenerate() ...

13 years, 6 months ago (2011-07-07 14:15:54 UTC) #2

closed with r1817

Expand All Messages | Collapse All Messages