Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(565)

Issue 4675062: Fix div by zero in GPU degenerate radials (and add sample) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 5 months ago by bsalomon
Modified:
13 years, 5 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix name, add gm baselines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -75 lines) Patch
A gm/base-linux/gradients_degenerate_2pt_4444.png View 1 Binary file 0 comments Download
A gm/base-linux/gradients_degenerate_2pt_565.png View 1 Binary file 0 comments Download
A gm/base-linux/gradients_degenerate_2pt_8888.png View 1 Binary file 0 comments Download
A gm/base-linux/gradients_degenerate_2pt_gpu.png View 1 Binary file 0 comments Download
M gpu/include/GrSamplerState.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M gpu/src/GrGLProgram.h View 1 2 chunks +6 lines, -1 line 0 comments Download
M gpu/src/GrGLProgram.cpp View 1 11 chunks +49 lines, -17 lines 0 comments Download
M gpu/src/GrGpuGLShaders.cpp View 1 5 chunks +20 lines, -8 lines 0 comments Download
M gyp/SampleApp.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
A samplecode/SampleDegenerateTwoPtRadials.cpp View 1 1 chunk +85 lines, -0 lines 0 comments Download
M samplecode/SampleXfermodesBlur.cpp View 1 3 chunks +1 line, -49 lines 0 comments Download

Messages

Total messages: 3
bsalomon
Still work to do around near-degenerate (for both SW and GPU)
13 years, 5 months ago (2011-07-07 14:11:54 UTC) #1
reed1
LGTM w/ possible name change http://codereview.appspot.com/4675062/diff/1/gpu/include/GrSamplerState.h File gpu/include/GrSamplerState.h (right): http://codereview.appspot.com/4675062/diff/1/gpu/include/GrSamplerState.h#newcode207 gpu/include/GrSamplerState.h:207: // equation. bool radial2IsDegenerate() ...
13 years, 5 months ago (2011-07-07 14:15:54 UTC) #2
bsalomon
13 years, 5 months ago (2011-07-08 16:23:49 UTC) #3
closed with r1817
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b