Issue 46730043: Doc: NR 2.4.1 - add Hammer/Pull snippets

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 46730043: Doc: NR 2.4.1 - add Hammer/Pull snippets (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 4 months ago by pkx166h

Modified:
10 years, 3 months ago

Reviewers:
fedelogy, Trevor Daniels

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Doc: NR 2.4.1 - add Hammer/Pull snippets Issue 2594 Added 3 snippets illustrating Hammer-on and Pull-off in different circumstances Normal use With Voices With Chorded notes Included @cindex entries

Patch Set 2 : Minor tweaks to snippets #

Patch Set 3 : With minor corrections from Trevor and without the makelsr.py automatic snippet-doc updates #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+71 lines, -0 lines)			Patch
M	Documentation/notation/fretted-strings.itely	View		1 chunk	+12 lines, -0 lines	0 comments	Download
A	Documentation/snippets/new/hammer-on-and-pull-off.ly	View	1	1 chunk	+18 lines, -0 lines	0 comments	Download
A	Documentation/snippets/new/hammer-on-and-pull-off-using-chords.ly	View	1 2	1 chunk	+21 lines, -0 lines	0 comments	Download
A	Documentation/snippets/new/hammer-on-and-pull-off-using-voices.ly	View		1 chunk	+20 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Trevor Daniels

LGTM, apart from a couple of nits https://codereview.appspot.com/46730043/diff/1/Documentation/snippets/new/hammer-on-and-pull-off-using-chords.ly File Documentation/snippets/new/hammer-on-and-pull-off-using-chords.ly (right): https://codereview.appspot.com/46730043/diff/1/Documentation/snippets/new/hammer-on-and-pull-off-using-chords.ly#newcode8 Documentation/snippets/new/hammer-on-and-pull-off-using-chords.ly:8: is drawn. ...

10 years, 4 months ago (2013-12-31 14:59:12 UTC) #1

pkx166h

With minor corrections from Trevor and without the makelsr.py automatic snippet-doc updates

10 years, 4 months ago (2013-12-31 15:24:00 UTC) #3

pkx166h

10 years, 3 months ago (2014-01-06 07:17:08 UTC) #5

authorJames Lowe <pkx166h@gmail.com>
 Mon, 6 Jan 2014 07:14:53 +0000 (07:14 +0000)
committerJames Lowe <pkx166h@gmail.com>
 Mon, 6 Jan 2014 07:15:48 +0000 (07:15 +0000)
commit51230c664c23bcf4b281d3097afd35a3014714f7

Expand All Messages | Collapse All Messages