Issue 4670056: Fix 1390: slashedGrace function (graces with slashed stems but no slur, e.g. when grace is tied)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4670056: Fix 1390: slashedGrace function (graces with slashed stems but no slur, e.g. when grace is tied) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 9 months ago by Reinhold

Modified:
13 years, 9 months ago

Reviewers:
markpolesky, James.Lowe

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Fix 1390: slashedGrace function (graces with slashed stems but no slur, e.g. when grace is tied)

Patch Set 1 #

Created: 13 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -0 lines)			Patch
A	input/regression/grace-slashed-no-slur.ly	View	1 chunk	+11 lines, -0 lines	0 comments	Download
M	ly/grace-init.ly	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	ly/music-functions-init.ly	View	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

markpolesky_yahoo.com

> http://codereview.appspot.com/4670056/ Reinhold, I think the slashedGrace function needs to be described in the NR ...

13 years, 9 months ago (2011-07-23 16:20:31 UTC) #3

James.Lowe_datacore.com

13 years, 9 months ago (2011-07-23 22:16:53 UTC) #4

Hello
________________________________________
From: lilypond-devel-bounces+james.lowe=datacore.com@gnu.org
[lilypond-devel-bounces+james.lowe=datacore.com@gnu.org] on behalf of Mark
Polesky [markpolesky@yahoo.com]
Sent: 23 July 2011 17:20
To: reinhold.kainhofer@gmail.com
Cc: reply@codereview.appspotmail.com; lilypond-devel@gnu.org
Subject: Re: Fix 1390: slashedGrace function (graces with slashed stems but no 
slur, e.g. when grace is tied) (issue4670056)

> http://codereview.appspot.com/4670056/

Reinhold,

I think the slashedGrace function needs to be described in
the NR (1.2.6), and also preferably listed in changes.tely.

Thanks.
- Mark
-----------

Added as 

http://code.google.com/p/lilypond/issues/detail?id=1778

James

Expand All Messages | Collapse All Messages