Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(64)

Issue 4668060: Fixed an error in IBus.Bus.register_component (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 11 months ago by fujiwara
Modified:
12 years, 11 months ago
Reviewers:
shawn.p.huang, Peng
CC:
shawn.p.huang_gmail.com, fujiwara
Base URL:
git://github.com/ibus/ibus.git@master
Visibility:
Public.

Description

Fixed an error in IBus.Bus.register_component TEST=Linux desktop

Patch Set 1 #

Patch Set 2 : Merged with master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M ibus/component.py View 3 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 3
fujiwara
Currently the python IBus.component.add_engine is not useful when we will add a new property. I ...
12 years, 11 months ago (2011-07-07 08:05:46 UTC) #1
Peng
LGTM
12 years, 11 months ago (2011-07-11 13:25:33 UTC) #2
Peng
12 years, 11 months ago (2011-07-11 13:26:06 UTC) #3
On 2011/07/11 13:25:33, Peng wrote:
> LGTM

BTW, I added you as committor. You could use git cl push to submit the CL.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b