Issue 4667067: Fix several GVariant related issues. And remove a wrong unref.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4667067: Fix several GVariant related issues. And remove a wrong unref. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 11 months ago by Peng

Modified:
12 years, 11 months ago

Reviewers:
Yusuke Sato

CC:
bryeung_google.com

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

Description

Fix several GVariant related issues. And remove a wrong unref. BUG=None TEST=Linux desktop

Patch Set 1 #

Created: 12 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -13 lines)			Patch
M	bus/ibusimpl.c	View	3 chunks	+5 lines, -6 lines	0 comments	Download
M	bus/inputcontext.c	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/ibusconfig.c	View	4 chunks	+2 lines, -6 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Yusuke Sato

On 2011/07/07 16:21:37, Peng wrote: lgtm So you fixed several use-after-free errors, correct? If so, ...

12 years, 11 months ago (2011-07-07 16:34:34 UTC) #2

Peng

On 2011/07/07 16:34:34, Yusuke Sato wrote: > On 2011/07/07 16:21:37, Peng wrote: > > lgtm ...

12 years, 11 months ago (2011-07-07 17:04:34 UTC) #3

Peng

12 years, 11 months ago (2011-07-07 17:43:16 UTC) #4

On 2011/07/07 17:04:34, Peng wrote:
> On 2011/07/07 16:34:34, Yusuke Sato wrote:
> > On 2011/07/07 16:21:37, Peng wrote:
> > 
> > lgtm
> > 
> > So you fixed several use-after-free errors, correct? If so, should we merge
it
> > to chromeos R13 branch? In other words, does the bug trigger a practical
> > problem, like ibus-daemon/chrome SEGV?
> 
> I think it is better to fix them in R13. I found sometime the hotkey does not
> work without this fix. I am not sure if it is a same problem with
> crosbug.com/15773 .

I just reproduced crosbug.com/15773 with this CL.

Expand All Messages | Collapse All Messages