Add org.freedesktop.IBus.Config.GetValues to get all values in one RPC.

Add org.freedesktop.IBus.Config.GetValues to get all values in one RPC.


BUG=http://crosbug.com/16287
TEST=Linux desktop

[Yusuke Sato, 2011-07-05 05:20:53]

could you update src/tests/ibus-config.c as well?

http://codereview.appspot.com/4667056/diff/2001/src/ibusconfig.c
File src/ibusconfig.c (right):

http://codereview.appspot.com/4667056/diff/2001/src/ibusconfig.c#newcode303
src/ibusconfig.c:303: g_variant_get (retval, "(@a{sv})", &value);
is this change intentional??

http://codereview.appspot.com/4667056/diff/2001/src/ibusconfig.h
File src/ibusconfig.h (right):

http://codereview.appspot.com/4667056/diff/2001/src/ibusconfig.h#newcode199
src/ibusconfig.h:199: * @timeout_msec: The timeout in milliseconds or -1 to use
the default timeout.
@timeout_ms:

http://codereview.appspot.com/4667056/diff/2001/src/ibusconfig.h#newcode217
src/ibusconfig.h:217: * @confi: A #IBusConfig.
@config:

[Yusuke Sato, 2011-07-05 05:21:19]

other than that, lgtm.

On 2011/07/05 05:20:53, Yusuke Sato wrote:
> could you update src/tests/ibus-config.c as well?
> 
> http://codereview.appspot.com/4667056/diff/2001/src/ibusconfig.c
> File src/ibusconfig.c (right):
> 
> http://codereview.appspot.com/4667056/diff/2001/src/ibusconfig.c#newcode303
> src/ibusconfig.c:303: g_variant_get (retval, "(@a{sv})", &value);
> is this change intentional??
> 
> http://codereview.appspot.com/4667056/diff/2001/src/ibusconfig.h
> File src/ibusconfig.h (right):
> 
> http://codereview.appspot.com/4667056/diff/2001/src/ibusconfig.h#newcode199
> src/ibusconfig.h:199: * @timeout_msec: The timeout in milliseconds or -1 to
use
> the default timeout.
> @timeout_ms:
> 
> http://codereview.appspot.com/4667056/diff/2001/src/ibusconfig.h#newcode217
> src/ibusconfig.h:217: * @confi: A #IBusConfig.
> @config:

[Peng, 2011-07-05 14:42:24]

Added test cases for config too.

http://codereview.appspot.com/4667056/diff/2001/src/ibusconfig.c
File src/ibusconfig.c (right):

http://codereview.appspot.com/4667056/diff/2001/src/ibusconfig.c#newcode303
src/ibusconfig.c:303: g_variant_get (retval, "(@a{sv})", &value);
On 2011/07/05 05:20:53, Yusuke Sato wrote:
> is this change intentional??
Yeah.

Upon encountering a '@' in front of a type string, g_variant_get() takes a
pointer to a (GVariant *) (ie: a (GVariant **)) and sets it to a new reference
to a GVariant containing the value (instead of deconstructing the value into C
types in the usual way). NULL can be given to ignore the value. '*', '?' and 'r'
are handled in a way analogous to what is stated above.

http://codereview.appspot.com/4667056/diff/2001/src/ibusconfig.h
File src/ibusconfig.h (right):

http://codereview.appspot.com/4667056/diff/2001/src/ibusconfig.h#newcode199
src/ibusconfig.h:199: * @timeout_msec: The timeout in milliseconds or -1 to use
the default timeout.
On 2011/07/05 05:20:53, Yusuke Sato wrote:
> @timeout_ms:

Done.

http://codereview.appspot.com/4667056/diff/2001/src/ibusconfig.h#newcode217
src/ibusconfig.h:217: * @confi: A #IBusConfig.
On 2011/07/05 05:20:53, Yusuke Sato wrote:
> @config:

Done.