Issue 4664056: Fix pdf img macros for windows builds

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4664056: Fix pdf img macros for windows builds (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 2 months ago by bsalomon

Modified:
13 years, 2 months ago

Reviewers:
bungeman, epoger, reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 1 #

Total comments: 1

Created: 13 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	gm/gmmain.cpp	View		1 chunk	+2 lines, -2 lines	1 comment	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

bungeman

On 2011/06/29 19:34:04, bsalomon wrote: > "true" and "false" aren't valid in #if on windows ...

13 years, 2 months ago (2011-06-29 19:37:09 UTC) #2

epoger

http://codereview.appspot.com/4664056/diff/1/gm/gmmain.cpp File gm/gmmain.cpp (right): http://codereview.appspot.com/4664056/diff/1/gm/gmmain.cpp#newcode24 gm/gmmain.cpp:24: #define CAN_IMAGE_PDF 1 Why aren't we just either defining ...

13 years, 2 months ago (2011-06-29 19:54:32 UTC) #4

reed1

13 years, 2 months ago (2011-06-29 20:05:28 UTC) #5

'cause only some platforms can 'image' pdf, all can generate it.

However, if we switch to multiple impls of the same header (see my
prev comments), I think we can remove that, and just rely on the
runtime return from the call.

On Wed, Jun 29, 2011 at 3:54 PM,  <epoger@google.com> wrote:
>
> http://codereview.appspot.com/4664056/diff/1/gm/gmmain.cpp
> File gm/gmmain.cpp (right):
>
> http://codereview.appspot.com/4664056/diff/1/gm/gmmain.cpp#newcode24
> gm/gmmain.cpp:24: #define CAN_IMAGE_PDF   1
> Why aren't we just either defining these symbols or not (a la
> SK_SUPPORT_PDF), so we can just use #ifdef ?
>
> http://codereview.appspot.com/4664056/
>

Expand All Messages | Collapse All Messages