Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(228)

Issue 4661057: alphabetic listing of global index, code modified

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 6 months ago by sinha
Modified:
13 years, 5 months ago
Reviewers:
Reimar Bauer
Visibility:
Public.

Patch Set 1 #

Total comments: 5

Patch Set 2 : regex employed for filtering #

Total comments: 4

Patch Set 3 : frontend modified and some backend functions #

Total comments: 8

Patch Set 4 : item index link added beside each item name #

Total comments: 12

Patch Set 5 : change in view, modification in backend codes #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -14 lines) Patch
M MoinMoin/apps/frontend/views.py View 1 2 3 4 1 chunk +24 lines, -2 lines 4 comments Download
M MoinMoin/items/__init__.py View 1 2 3 4 1 chunk +15 lines, -4 lines 0 comments Download
M MoinMoin/templates/global_index.html View 1 2 3 4 1 chunk +31 lines, -8 lines 0 comments Download
M MoinMoin/themes/modernized/static/css/common.css View 1 2 3 4 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 14
Reimar Bauer
some questions http://codereview.appspot.com/4661057/diff/1/MoinMoin/apps/frontend/views.py File MoinMoin/apps/frontend/views.py (right): http://codereview.appspot.com/4661057/diff/1/MoinMoin/apps/frontend/views.py#newcode489 MoinMoin/apps/frontend/views.py:489: prefix = request.values.get('prefix', None) What is the ...
13 years, 6 months ago (2011-06-29 06:36:30 UTC) #1
sinha
http://codereview.appspot.com/4661057/diff/1/MoinMoin/items/__init__.py File MoinMoin/items/__init__.py (right): http://codereview.appspot.com/4661057/diff/1/MoinMoin/items/__init__.py#newcode578 MoinMoin/items/__init__.py:578: def flat_index(self, prefix=None): On 2011/06/29 06:36:30, Reimar Bauer wrote: ...
13 years, 6 months ago (2011-06-29 06:44:48 UTC) #2
Reimar Bauer
questions http://codereview.appspot.com/4661057/diff/5001/MoinMoin/items/__init__.py File MoinMoin/items/__init__.py (right): http://codereview.appspot.com/4661057/diff/5001/MoinMoin/items/__init__.py#newcode578 MoinMoin/items/__init__.py:578: def flat_index(self, startsWith=None): PEP8 for parameter http://codereview.appspot.com/4661057/diff/5001/MoinMoin/items/__init__.py#newcode580 MoinMoin/items/__init__.py:580: ...
13 years, 6 months ago (2011-06-29 15:57:45 UTC) #3
Reimar Bauer
the proper name of the method is may be name_initial but it should then do ...
13 years, 5 months ago (2011-07-02 06:33:59 UTC) #4
sinha
http://codereview.appspot.com/4661057/diff/8005/MoinMoin/templates/global_index.html File MoinMoin/templates/global_index.html (right): http://codereview.appspot.com/4661057/diff/8005/MoinMoin/templates/global_index.html#newcode23 MoinMoin/templates/global_index.html:23: {% for fullname, relname, contenttype in index[i:i+4] %} On ...
13 years, 5 months ago (2011-07-02 06:53:25 UTC) #5
Reimar Bauer
see comment http://codereview.appspot.com/4661057/diff/8005/MoinMoin/templates/global_index.html File MoinMoin/templates/global_index.html (right): http://codereview.appspot.com/4661057/diff/8005/MoinMoin/templates/global_index.html#newcode23 MoinMoin/templates/global_index.html:23: {% for fullname, relname, contenttype in index[i:i+4] ...
13 years, 5 months ago (2011-07-02 08:49:37 UTC) #6
Reimar Bauer
ep http://codereview.appspot.com/4661057/diff/8005/MoinMoin/items/__init__.py File MoinMoin/items/__init__.py (right): http://codereview.appspot.com/4661057/diff/8005/MoinMoin/items/__init__.py#newcode578 MoinMoin/items/__init__.py:578: def flat_index(self, startswith=None): see etherpad +182
13 years, 5 months ago (2011-07-02 08:50:54 UTC) #7
sinha
Now links for item index have been added beside each item name, need to know ...
13 years, 5 months ago (2011-07-04 12:40:48 UTC) #8
Reimar Bauer
some questions some unspecific vars line 498 - 508 in views.py sounds like it should ...
13 years, 5 months ago (2011-07-04 15:40:03 UTC) #9
sinha
http://codereview.appspot.com/4661057/diff/12002/MoinMoin/items/__init__.py File MoinMoin/items/__init__.py (right): http://codereview.appspot.com/4661057/diff/12002/MoinMoin/items/__init__.py#newcode592 MoinMoin/items/__init__.py:592: letters = [(name[1][0]) On 2011/07/04 15:40:03, Reimar Bauer wrote: ...
13 years, 5 months ago (2011-07-04 18:52:12 UTC) #10
Reimar Bauer
answered http://codereview.appspot.com/4661057/diff/12002/MoinMoin/items/__init__.py File MoinMoin/items/__init__.py (right): http://codereview.appspot.com/4661057/diff/12002/MoinMoin/items/__init__.py#newcode592 MoinMoin/items/__init__.py:592: letters = [(name[1][0]) On 2011/07/04 18:52:12, sinha wrote: ...
13 years, 5 months ago (2011-07-04 20:56:17 UTC) #11
Reimar Bauer
some small issues http://codereview.appspot.com/4661057/diff/17003/MoinMoin/apps/frontend/views.py File MoinMoin/apps/frontend/views.py (right): http://codereview.appspot.com/4661057/diff/17003/MoinMoin/apps/frontend/views.py#newcode500 MoinMoin/apps/frontend/views.py:500: index_more_links = [] this is the ...
13 years, 5 months ago (2011-07-06 07:47:21 UTC) #12
sinha
reg variable naming http://codereview.appspot.com/4661057/diff/17003/MoinMoin/apps/frontend/views.py File MoinMoin/apps/frontend/views.py (right): http://codereview.appspot.com/4661057/diff/17003/MoinMoin/apps/frontend/views.py#newcode500 MoinMoin/apps/frontend/views.py:500: index_more_links = [] On 2011/07/06 07:47:21, ...
13 years, 5 months ago (2011-07-06 10:57:09 UTC) #13
Reimar Bauer
13 years, 5 months ago (2011-07-06 11:05:50 UTC) #14
ok

http://codereview.appspot.com/4661057/diff/17003/MoinMoin/apps/frontend/views.py
File MoinMoin/apps/frontend/views.py (right):

http://codereview.appspot.com/4661057/diff/17003/MoinMoin/apps/frontend/views...
MoinMoin/apps/frontend/views.py:500: index_more_links = []
On 2011/07/06 10:57:09, sinha wrote:
> On 2011/07/06 07:47:21, Reimar Bauer wrote:
> > this is the var for [..] flagging?
> > link_to_item_indexes ?
> 
> this var has one more field than the original index, that extra field is
> link_to_item_indexes, thats why i named it as index_more_links .

ok
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b