Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2125)

Issue 4657067: Don't send NULL buffer data hint in chrome (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 4 months ago by bsalomon
Modified:
13 years, 4 months ago
Reviewers:
reed1, TomH
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M gpu/include/GrGLConfig.h View 2 chunks +14 lines, -0 lines 0 comments Download
M gpu/include/GrGLConfig_chrome.h View 1 chunk +4 lines, -0 lines 0 comments Download
M gpu/src/GrGLIndexBuffer.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/src/GrGLVertexBuffer.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6
bsalomon
13 years, 4 months ago (2011-07-01 15:01:45 UTC) #1
TomH
On 2011/07/01 15:01:45, bsalomon wrote: LGTM. To echo a recent review, though, do we have ...
13 years, 4 months ago (2011-07-01 15:06:10 UTC) #2
bsalomon
In Ganesh we always define all configurable macros. We only use #ifdef to set default ...
13 years, 4 months ago (2011-07-01 15:09:32 UTC) #3
reed1
LGTM is this a candidate for runtime flag in GLInterfaces, rather than compile-time?
13 years, 4 months ago (2011-07-01 15:13:39 UTC) #4
bsalomon
On Fri, Jul 1, 2011 at 11:13 AM, <reed@google.com> wrote: > LGTM > > is ...
13 years, 4 months ago (2011-07-01 15:21:33 UTC) #5
bsalomon
13 years, 4 months ago (2011-07-01 15:22:17 UTC) #6
Closed with r1778.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b