Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(578)

Issue 4657043: Coverity Fixlet - UNINIT_CTOR (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 4 months ago by scr
Modified:
13 years, 4 months ago
Reviewers:
bsalomon, reed1
CC:
skia-review_googlegroups.com, Steve VanDeBogart
Base URL:
http://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

Coverity Fixlet - UNINIT_CTOR http://chromecoverity.mtv.corp.google.com:5467/cov.cgi?events=17510516&line=127&prec=%2Fcov.cgi%3Fc%3DAAAAAAHA5g%26checker%3D55_56%26class%3D1_2_5%26comp%3DThird-party%26file%3D%252Fskia%252F%26q%3D6%26runs%3D924%26t%3D6%26v%3D1&run=924&t=12&v=1#line122 CID=16834,14530,16769 BUG= TEST=

Patch Set 1 #

Patch Set 2 : Making minimal changes for coverity, rather than moving to implementation file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -9 lines) Patch
M gpu/include/GrSamplerState.h View 1 6 chunks +23 lines, -9 lines 0 comments Download

Messages

Total messages: 6
scr
Please review this Coverity Fixlet in Skia. I made an implementation file GrSamplerState.cpp and used ...
13 years, 4 months ago (2011-06-21 19:17:01 UTC) #1
bsalomon
On 2011/06/21 19:17:01, scr wrote: > Please review this Coverity Fixlet in Skia. > > ...
13 years, 4 months ago (2011-06-21 19:22:58 UTC) #2
reed1
don't submit yet Where all of the white-space changes? The indents have changed in most ...
13 years, 4 months ago (2011-06-21 19:33:14 UTC) #3
scr
Ok, how 'bout this minimal change - only the header - only init the variables, ...
13 years, 4 months ago (2011-06-21 19:53:33 UTC) #4
reed1
Sweet. LGTM
13 years, 4 months ago (2011-06-21 20:06:49 UTC) #5
bsalomon
13 years, 4 months ago (2011-06-21 20:32:26 UTC) #6
checked in at r1665
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b