Issue 4654085: First stab at using the left and right bound detail callbacks.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4654085: First stab at using the left and right bound detail callbacks. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 10 months ago by MikeSol

Modified:
13 years, 10 months ago

Reviewers:
Neil Puttock

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

First stab at using the left and right bound detail callbacks.

Patch Set 1 #

Created: 13 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+41 lines, -31 lines)			Patch
M	lily/line-spanner.cc	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	scm/define-grobs.scm	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	scm/output-lib.scm	View	1 chunk	+36 lines, -25 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

MikeSol

>Hah, it also works fine if you use left/right-bound-info (as I >originally suggested. ;) > ...

13 years, 10 months ago (2011-07-03 21:21:51 UTC) #1

Neil Puttock

13 years, 10 months ago (2011-07-03 21:33:06 UTC) #2

On 2011/07/03 21:21:51, MikeSol wrote:
> >Hah, it also works fine if you use left/right-bound-info (as I
> >originally suggested. ;)
> >
> >Cheers,
> >Neil
> 
> Hey Neil,
> 
> I tried to implement your suggestion via the logic in this patch, but it
doesn't
> seem to work (it gets the same result as the current master).  Any pointers?

Two things stick out:

1) You need to prevent calc_bound_info () from generating 'Y if simple-Y is set;

2) Don't set bound-details.  You should return the revised bound-info,
i.e., read the left/right default bound-info, calculate new-Y as before then
acons new-Y to old bound-info.

Expand All Messages | Collapse All Messages