combine target_defaults.gypi into common.gypi

platform-dependent settings were spread across these two files, and all our gyp targets were including both of these files anyway... so combined them.

[bungeman, 2011-07-01 17:08:16]

On 2011/07/01 16:20:41, epoger wrote:

LGTM

[epoger, 2011-07-01 17:17:26]

committed as r1780

Before committing, I patched this change into Linux, Mac, and Windows
environments, and confirmed that "tests" and "SampleApp" still built ok.

[Stephen White, 2011-07-04 20:55:05]

Thanks for cleaning this up.

http://codereview.appspot.com/4654080/diff/1/gyp/common.gypi
File gyp/common.gypi (right):

http://codereview.appspot.com/4654080/diff/1/gyp/common.gypi#newcode70
gyp/common.gypi:70: 'OpenGL32.lib',
Hmmm.. does this mean that all binaries will link against OpenGL?  Is that
necessary?

Also, it looks like Mac and Linux specify this dependency in gpu.gyp.  We should
probably do it in the same file on all platforms.

[bungeman, 2011-07-06 12:30:55]

On 2011/07/04 20:55:05, Stephen White wrote:
> Thanks for cleaning this up.
> 
> http://codereview.appspot.com/4654080/diff/1/gyp/common.gypi
> File gyp/common.gypi (right):
> 
> http://codereview.appspot.com/4654080/diff/1/gyp/common.gypi#newcode70
> gyp/common.gypi:70: 'OpenGL32.lib',
> Hmmm.. does this mean that all binaries will link against OpenGL?  Is that
> necessary?
> 
> Also, it looks like Mac and Linux specify this dependency in gpu.gyp.  We
should
> probably do it in the same file on all platforms.

Yes, it does mean they all link against OpenGL. This was true before as well,
this change simply made it easier to see. This is something which needs to be
cleaned up, so that each component which actually needs these libraries brings
them in as they need them.

[Stephen White, 2011-07-06 15:27:16]

On 2011/07/06 12:30:55, bungeman wrote:
> On 2011/07/04 20:55:05, Stephen White wrote:
> > Thanks for cleaning this up.
> > 
> > http://codereview.appspot.com/4654080/diff/1/gyp/common.gypi
> > File gyp/common.gypi (right):
> > 
> > http://codereview.appspot.com/4654080/diff/1/gyp/common.gypi#newcode70
> > gyp/common.gypi:70: 'OpenGL32.lib',
> > Hmmm.. does this mean that all binaries will link against OpenGL?  Is that
> > necessary?
> > 
> > Also, it looks like Mac and Linux specify this dependency in gpu.gyp.  We
> should
> > probably do it in the same file on all platforms.
> 
> Yes, it does mean they all link against OpenGL. This was true before as well,
> this change simply made it easier to see. This is something which needs to be
> cleaned up, so that each component which actually needs these libraries brings
> them in as they need them.

I think by doing this the way the Mac and Linux ports do it (by putting the
dependency in gpu.gyp and utils.gyp), this should Just Work:  anything that
links in libraries that make GL calls will link against OpenGL.