Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(523)

Issue 4654071: Create new lcdtext page within gm (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 11 months ago by epoger
Modified:
12 years, 11 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Should get this in place before committing http://codereview.appspot.com/4625071 ('Fix build for old versions of freetype without FT_Library_SetLcdFilter') This CL contains just the image-generating code; the baseline images will be committed separately once this is approved. In the meanwhile, the buildbot will not turn red just because of missing baseline image files.

Patch Set 1 #

Patch Set 2 : black text on white background (instead of reverse) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -0 lines) Patch
A gm/lcdtext.cpp View 1 1 chunk +82 lines, -0 lines 0 comments Download
M gyp/gm.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6
epoger
12 years, 11 months ago (2011-06-28 15:47:39 UTC) #1
reed1
prolly fine, tho the std way people evaluate lcd text (usually) is black text on ...
12 years, 11 months ago (2011-06-28 16:00:01 UTC) #2
epoger
On 2011/06/28 16:00:01, reed1 wrote: > prolly fine, tho the std way people evaluate lcd ...
12 years, 11 months ago (2011-06-28 16:08:16 UTC) #3
epoger
12 years, 11 months ago (2011-06-28 16:08:20 UTC) #4
reed1
LGTM
12 years, 11 months ago (2011-06-28 16:17:52 UTC) #5
epoger
12 years, 11 months ago (2011-06-28 16:21:07 UTC) #6
committed as r1736

will add baseline images next.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b