New breve rest with ledger lines

New breve rest with ledger lines

[Bertrand Bordage, 2011-06-22 23:34:05]

Minor patch that adds a useful glyph for baroque music.

[Keith, 2011-06-23 05:01:33]

What is required to demonstrate this ?
I thought of
\relative c'' {
  \override Staff.NoteHead  #'style = #'mensural
  \override Staff.Rest  #'style = #'mensural
  \time 4/2
  << {
    g'1\rest b1\rest g\breve\rest b\breve\rest d\breve\rest
  } \\ {
    c,1 r2 r4 r4 r\breve r\breve r\breve
  } >>
}

but I don't see your new glyphs.
 
More importantly, the patch as it stands breaks breve rests outside the staff
for styles other than mensural (as if you remove the \overrides above.)

http://codereview.appspot.com/4650052/diff/1/lily/rest.cc
File lily/rest.cc (right):

http://codereview.appspot.com/4650052/diff/1/lily/rest.cc#newcode83
lily/rest.cc:83: if (try_ledgers && (balltype == 0 || balltype == 1 || balltype
== -1))
Less risk of future mistakes if you go in order: -1, 0, 1
and on lines 93-95 as well

http://codereview.appspot.com/4650052/diff/1/lily/rest.cc#newcode95
lily/rest.cc:95: is_ledgered |= (balltype == -1) && (pos <= -rad - 3 || pos >=
+rad + 2);
Either   ...&& style == "mensual"   
or below trap cases for which there is no rest in the font, 
or best of all give us ledgered breve rests for the default style as well

[Bertrand Bordage, 2011-06-23 09:34:23]

Updated with the good bounds.

The problem with mensural/neomensural/Petrucci styles is that they often have
different ledger line thicknesses. The best solution is to get these ledger
lines out of metafont. But this requires much more work.

For the moment, the exception is handled by the next "if", line 100.

Thanks!
Bertrand

[Graham Percival (old account), 2011-06-23 11:24:42]

thanks, added as
http://code.google.com/p/lilypond/issues/detail?id=1705

[Keith, 2011-06-24 00:45:24]

On 2011/06/23 09:34:23, Bertrand Bordage wrote:
> For the moment, the exception is handled by the next "if", line 100.

But don't forget to let /something/ print if the ledgered version is missing in
the chosen style -- especially default :

\relative c''' { \time 4/1
  << {
    b\breve\rest g\breve
  } \\ {
    c,\breve b\breve
  } >> }

I think you currently set is_ledgered = true for the b\breve\rest, and then
Lilypond looks for a glyph that does not exist.

[Bertrand Bordage, 2011-06-24 00:56:43]

Maybe I should have been more clear in the description.
The glyph I added in feta-rests.mf is for the default style. You have to remove
mf/out/feta* before compiling.
There's no problem when I try this patch with your example.
But again, maybe I don't understand what you mean.

Thanks

[Keith, 2011-06-24 02:00:49]

On 2011/06/24 00:56:43, Bertrand Bordage wrote:
> You have to remove mf/out/feta* before compiling.

That made everything work.   Looks good to me.

I was failing to find a glyph for rests.-1o , saw you were creating a new
rests.M1o and thought "Oh, 'M' must mean mensural" but I see it really does mean
'minus'.

[Bertrand Bordage, 2011-06-24 12:19:17]

Yes, sorry for that.
Just for information, ancient fonts are stored in the parmesan-* files.
For the ancient fonts, we really need to think about a less hard-coded solution.

[Carl, 2011-07-05 05:14:28]

LGTM

Carl