Indexed drawing for paths with multiple contours

[TomH, 2011-07-01 20:18:54]

LGTM

http://codereview.appspot.com/4648071/diff/6/gpu/src/GrPathRenderer.cpp
File gpu/src/GrPathRenderer.cpp (right):

http://codereview.appspot.com/4648071/diff/6/gpu/src/GrPathRenderer.cpp#newco...
gpu/src/GrPathRenderer.cpp:316: if (kHairLine_PathFill != fFill) {
It'd be a little clearer if we checked this once outside the loop and stored it
in a named variable (since we use it 3 times over, and it isn't obvious why the
fill matters as to what indices we create - I get it only because we talked it
over a day or two ago).

[bsalomon, 2011-07-01 22:05:43]

Hey Tom, Check out the latest version. The index append should be clearer.

On 2011/07/01 20:18:54, TomH wrote:
> LGTM
> 
> http://codereview.appspot.com/4648071/diff/6/gpu/src/GrPathRenderer.cpp
> File gpu/src/GrPathRenderer.cpp (right):
> 
>
http://codereview.appspot.com/4648071/diff/6/gpu/src/GrPathRenderer.cpp#newco...
> gpu/src/GrPathRenderer.cpp:316: if (kHairLine_PathFill != fFill) {
> It'd be a little clearer if we checked this once outside the loop and stored
it
> in a named variable (since we use it 3 times over, and it isn't obvious why
the
> fill matters as to what indices we create - I get it only because we talked it
> over a day or two ago).

[TomH, 2011-07-06 15:40:14]

On 2011/07/01 22:05:43, bsalomon wrote:
> Hey Tom, Check out the latest version. The index append should be clearer.

Yes, LGerTM.

[bsalomon, 2011-07-06 17:47:49]

Closed with r1800.