Issue 4644053: Edited headers and includes to use ApplicationServices instead of Carbon for mac source files

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4644053: Edited headers and includes to use ApplicationServices instead of Carbon for mac source files (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by yangsu

Modified:
13 years ago

Reviewers:
epoger, reed1

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 2 : Included Coregraphics in SkAdvancedTypefaceMetrics #

Total comments: 2

Patch Set 3 : Added includes to SkTypeface_mac.h #

Created: 13 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -12 lines)			Patch
M	gyp/core.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	include/ports/SkTypeface_mac.h	View	1 2	1 chunk	+6 lines, -1 line	0 comments	Download
M	include/utils/mac/SkCGUtils.h	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	src/core/SkAdvancedTypefaceMetrics.cpp	View	1	2 chunks	+7 lines, -2 lines	0 comments	Download
M	src/ports/SkFontHost_mac_coretext.cpp	View		3 chunks	+12 lines, -5 lines	0 comments	Download
M	src/ports/SkImageDecoder_CG.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

yangsu

http://codereview.appspot.com/4644053/diff/2001/gyp/core.gyp File gyp/core.gyp (right): http://codereview.appspot.com/4644053/diff/2001/gyp/core.gyp#newcode296 gyp/core.gyp:296: '$(SDKROOT)/System/Library/Frameworks/ApplicationServices.framework', After the change, SkFontHost_mac_coretext.cpp now depends on ApplicationServices. ...

13 years ago (2011-06-20 21:57:08 UTC) #1

LGTM

Expand All Messages | Collapse All Messages