Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5779)

Issue 4643052: Fix touch handling in SampleApp (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years ago by Scroggo
Modified:
11 years, 9 months ago
Reviewers:
reed1
CC:
Leon
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Unify handleTouch and handleClick in SampleApp. Allow each sample to handle clicks in Android SampleApp. Remove SampleWindow::handleTouch. Allow an SkWindow to have multiple clicks. Add a pointer ID to SkView::Click. Committed: https://code.google.com/p/skia/source/detail?r=1673

Patch Set 1 #

Patch Set 2 : Style fixes. #

Patch Set 3 : Fix memory leaks; store pointer ID as a void* #

Total comments: 6

Patch Set 4 : Use method provided on SkTDArray #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -81 lines) Patch
M android_sample/SampleApp/jni/sample-jni.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M include/views/SkView.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M include/views/SkWindow.h View 1 2 3 chunks +4 lines, -3 lines 0 comments Download
M samplecode/SampleApp.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleApp.cpp View 1 2 3 chunks +6 lines, -36 lines 0 comments Download
M src/views/SkView.cpp View 1 2 1 chunk +5 lines, -4 lines 0 comments Download
M src/views/SkWindow.cpp View 1 2 3 3 chunks +52 lines, -36 lines 0 comments Download

Messages

Total messages: 6
Scroggo
13 years ago (2011-06-21 20:29:02 UTC) #1
Scroggo
New patch up for review.
13 years ago (2011-06-21 21:18:25 UTC) #2
reed1
LGTM with minor suggestions http://codereview.appspot.com/4643052/diff/6002/src/views/SkWindow.cpp File src/views/SkWindow.cpp (left): http://codereview.appspot.com/4643052/diff/6002/src/views/SkWindow.cpp#oldcode59 src/views/SkWindow.cpp:59: or fClicks.deleteAll(); http://codereview.appspot.com/4643052/diff/6002/src/views/SkWindow.cpp File src/views/SkWindow.cpp ...
13 years ago (2011-06-21 21:24:53 UTC) #3
Scroggo
New patch uploaded. http://codereview.appspot.com/4643052/diff/6002/src/views/SkWindow.cpp File src/views/SkWindow.cpp (left): http://codereview.appspot.com/4643052/diff/6002/src/views/SkWindow.cpp#oldcode59 src/views/SkWindow.cpp:59: On 2011/06/21 21:24:53, reed1 wrote: > ...
13 years ago (2011-06-21 21:32:14 UTC) #4
Scroggo
http://codereview.appspot.com/4643052/diff/6002/src/views/SkWindow.cpp File src/views/SkWindow.cpp (right): http://codereview.appspot.com/4643052/diff/6002/src/views/SkWindow.cpp#newcode381 src/views/SkWindow.cpp:381: // First, attempt to find an existing click with ...
13 years ago (2011-06-22 13:02:25 UTC) #5
reed1
13 years ago (2011-06-22 13:10:19 UTC) #6
http://codereview.appspot.com/4643052/diff/6002/src/views/SkWindow.cpp
File src/views/SkWindow.cpp (right):

http://codereview.appspot.com/4643052/diff/6002/src/views/SkWindow.cpp#newcod...
src/views/SkWindow.cpp:381: // First, attempt to find an existing click with
this owner.
Doh! You're right.

On 2011/06/21 21:32:14, Scroggo wrote:
> On 2011/06/21 21:24:53, reed1 wrote:
> > or
> > 
> > int index = fClicks.find(owner);
> This will not work (I would need to pass the Click itself, rather than the
owner
> pointer).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b