Issue 4642043: Use createPlatformSurface in the SampleApp

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4642043: Use createPlatformSurface in the SampleApp (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by Scroggo

Modified:
13 years ago

Reviewers:
bsalomon, reed1

CC:
Leon

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Better fix for changing the viewport in sample app. Create a platform description and base the size on the SkWindow in order to create a RenderTarget, which results in changing the viewport. This allows us to use only GR calls. In the Android sample app, fix the problem where nothing is drawn in the first frame, and default to drawing in GL.

Patch Set 1 #

Total comments: 2

Created: 13 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+37 lines, -11 lines)			Patch
M	android_sample/SampleApp/Android.mk	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	android_sample/SampleApp/jni/sample-jni.cpp	View	2 chunks	+18 lines, -1 line	0 comments	Download
M	samplecode/SampleApp.cpp	View	3 chunks	+17 lines, -10 lines	2 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

reed1

http://codereview.appspot.com/4642043/diff/1/samplecode/SampleApp.cpp File samplecode/SampleApp.cpp (right): http://codereview.appspot.com/4642043/diff/1/samplecode/SampleApp.cpp#newcode1337 samplecode/SampleApp.cpp:1337: #ifdef ANDROID why are we doing this on every ...

13 years ago (2011-06-16 17:51:13 UTC) #3

Scroggo

13 years ago (2011-06-16 18:06:27 UTC) #4

reed1

13 years ago (2011-06-16 18:22:31 UTC) #5

Doh. I clicked the wrong "Expand All" link.

Lets add a comment to the code to this effect (i.e. "Needed to get a draw after
the resize").

LGTM

Expand All Messages | Collapse All Messages