Issue 4641101: Use g_variant_dup_string for consistency

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4641101: Use g_variant_dup_string for consistency (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 11 months ago by Yusuke Sato

Modified:
12 years, 11 months ago

Reviewers:
shawn.p.huang, Peng Huang

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

Description

Use g_variant_dup_string for consistency. This fix is similar to https://github.com/ibus/ibus/commit/624c4451da2bd171bd8ac53a9b9dd2a4227ef67f . BUG=None TEST=None

Patch Set 2 : review fic #

Created: 12 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	bus/ibusimpl.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Peng

http://codereview.appspot.com/4641101/diff/1/bus/ibusimpl.c File bus/ibusimpl.c (left): http://codereview.appspot.com/4641101/diff/1/bus/ibusimpl.c#oldcode2166 bus/ibusimpl.c:2166: g_variant_get (variant, "s", &engine_name); This is correct. Just g_variant_dup_string()'s ...

12 years, 11 months ago (2011-07-11 12:05:53 UTC) #2

Yusuke Sato

12 years, 11 months ago (2011-07-11 12:57:06 UTC) #3

LGTM

Expand All Messages | Collapse All Messages