Issue 4641081: code review 4641081: exp/template: use MetodByName, add to build.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4641081: code review 4641081: exp/template: use MetodByName, add to build. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 10 months ago by r

Modified:
13 years, 10 months ago

Reviewers:

CC:
rsc, adg, r2, golang-dev

Visibility:
Public.

Description

exp/template: use MethodByName, add to build.

Patch Set 1 #

Patch Set 2 : diff -r a273a515c267 https://go.googlecode.com/hg/ #

Created: 13 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -12 lines)			Patch
	M	src/pkg/Makefile	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	src/pkg/exp/template/exec.go	View		3 chunks	+4 lines, -12 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 10 months ago (2011-06-29 03:14:08 UTC) #1

adg

On 29 June 2011 13:14, <r@golang.org> wrote: > exp/template: use MetodByName, add to build. s/tod/thod/

13 years, 10 months ago (2011-06-29 03:29:41 UTC) #2

On Jun 29, 2011, at 1:22 PM, Andrew Gerrand wrote: > On 29 June 2011 ...

13 years, 10 months ago (2011-06-29 03:40:38 UTC) #3

13 years, 10 months ago (2011-06-29 03:44:20 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=39e8a896d27c ***

exp/template: use MethodByName, add to build.

R=rsc, adg, r
CC=golang-dev
http://codereview.appspot.com/4641081

Expand All Messages | Collapse All Messages