Issue 4639102: [PDF] Add a concept of a substitute object to the SkPDFCatalog class.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4639102: [PDF] Add a concept of a substitute object to the SkPDFCatalog class. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 2 months ago by Steve VanDeBogart

Modified:
13 years, 2 months ago

Reviewers:

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

Description

[PDF] Add a concept of a substitute object to the SkPDFCatalog class. Code by Arthur Hsu, original code review: http://codereview.appspot.com/4650060/ Committed: http://code.google.com/p/skia/source/detail?r=1812

Patch Set 1 #

Created: 13 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+211 lines, -26 lines)			Patch
M	include/pdf/SkPDFCatalog.h	View	3 chunks	+35 lines, -0 lines	0 comments	Download
M	include/pdf/SkPDFTypes.h	View	3 chunks	+16 lines, -9 lines	0 comments	Download
M	src/pdf/SkPDFCatalog.cpp	View	3 chunks	+83 lines, -2 lines	0 comments	Download
M	src/pdf/SkPDFDocument.cpp	View	5 chunks	+12 lines, -7 lines	0 comments	Download
M	src/pdf/SkPDFTypes.cpp	View	4 chunks	+10 lines, -4 lines	0 comments	Download
M	tests/PDFPrimitivesTest.cpp	View	6 chunks	+55 lines, -4 lines	0 comments	Download