Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1590)

Issue 4639083: code review 4639083: reflect: MethodByName (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 9 months ago by r
Modified:
12 years, 9 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

reflect: MethodByName It's more common to ask for methods by name than by index, so might as well make it easy to do so.

Patch Set 1 #

Patch Set 2 : diff -r 2efa68a4183d https://go.googlecode.com/hg/ #

Total comments: 8

Patch Set 3 : diff -r 2efa68a4183d https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 2efa68a4183d https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 2efa68a4183d https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r 2efa68a4183d https://go.googlecode.com/hg/ #

Patch Set 7 : diff -r a1541ae18b69 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -5 lines) Patch
M src/pkg/reflect/all_test.go View 1 2 3 chunks +41 lines, -5 lines 0 comments Download
M src/pkg/reflect/type.go View 1 2 3 4 5 6 chunks +50 lines, -0 lines 0 comments Download
M src/pkg/reflect/value.go View 1 2 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 6
r
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 9 months ago (2011-06-29 00:59:10 UTC) #1
rsc
some simplifications http://codereview.appspot.com/4639083/diff/2001/src/pkg/reflect/type.go File src/pkg/reflect/type.go (right): http://codereview.appspot.com/4639083/diff/2001/src/pkg/reflect/type.go#newcode356 src/pkg/reflect/type.go:356: Func Value Please add Index int like ...
12 years, 9 months ago (2011-06-29 01:47:15 UTC) #2
r
Hello rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
12 years, 9 months ago (2011-06-29 02:47:51 UTC) #3
r
Hello rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
12 years, 9 months ago (2011-06-29 02:52:38 UTC) #4
rsc
LGTM
12 years, 9 months ago (2011-06-29 03:00:02 UTC) #5
r
12 years, 9 months ago (2011-06-29 03:11:58 UTC) #6
*** Submitted as http://code.google.com/p/go/source/detail?r=a273a515c267 ***

reflect: MethodByName
It's more common to ask for methods by name than by index, so might
as well make it easy to do so.

R=rsc
CC=golang-dev
http://codereview.appspot.com/4639083
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b