Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3421)

Issue 4639075: Moves tuplet numbers outside staff with their brackets. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 9 months ago by MikeSol
Modified:
8 years ago
Reviewers:
mike, hanwenn, Carl, Neil Puttock, carl.d.sorensen
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Moves tuplet numbers outside staff with their brackets.

Patch Set 1 #

Patch Set 2 : Fixes vertical spacing problem that Neil pointed out. #

Total comments: 3

Patch Set 3 : Minimizes interference with axis-group-interface.cc #

Total comments: 2

Patch Set 4 : Changes the duplicate Y axis to X axis #

Total comments: 2

Patch Set 5 : Limits check to the Y parent, circumventing segfault #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -6 lines) Patch
A input/regression/tuplet-bracket-outside-staff-priority.ly View 1 2 3 4 1 chunk +21 lines, -0 lines 0 comments Download
M lily/axis-group-interface.cc View 1 2 3 4 2 chunks +10 lines, -1 line 0 comments Download
M lily/context.cc View 1 2 3 4 1 chunk +2 lines, -5 lines 0 comments Download
M lily/include/axis-group-interface.hh View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M lily/tuplet-engraver.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 21
MikeSol
Useful for stuff like: \version "2.15" \relative c' { \override TupletBracket #'outside-staff-priority = #1 \times ...
12 years, 9 months ago (2011-06-27 17:38:04 UTC) #1
Neil Puttock
On 2011/06/27 17:38:04, MikeSol wrote: > Useful for stuff like: > > > \version "2.15" ...
12 years, 9 months ago (2011-06-27 21:56:00 UTC) #2
MikeSol
On 2011/06/27 21:56:00, Neil Puttock wrote: > This doesn't look too good: > > \relative ...
12 years, 9 months ago (2011-06-28 07:40:49 UTC) #3
hanwenn
This patch doesnt make sense to me. The TupletBracket grob is already linked to the ...
12 years, 9 months ago (2011-07-01 15:02:58 UTC) #4
mike_apollinemike.com
On Jul 1, 2011, at 5:02 PM, hanwenn@gmail.com wrote: > This patch doesnt make sense ...
12 years, 9 months ago (2011-07-01 15:44:15 UTC) #5
hanwenn
On Fri, Jul 1, 2011 at 12:44 PM, mike@apollinemike.com <mike@apollinemike.com> wrote: > On Jul 1, ...
12 years, 9 months ago (2011-07-01 16:09:35 UTC) #6
mike_apollinemike.com
On Jul 1, 2011, at 6:09 PM, Han-Wen Nienhuys wrote: > On Fri, Jul 1, ...
12 years, 9 months ago (2011-07-01 16:13:00 UTC) #7
MikeSol
On 2011/07/01 16:13:00, mike_apollinemike.com wrote: > On Jul 1, 2011, at 6:09 PM, Han-Wen Nienhuys ...
12 years, 8 months ago (2011-07-13 05:47:47 UTC) #8
hanwenn
On Fri, Jul 1, 2011 at 1:09 PM, Han-Wen Nienhuys <hanwenn@gmail.com> wrote: >> The problem ...
12 years, 8 months ago (2011-07-13 14:13:54 UTC) #9
mike_apollinemike.com
On Jul 13, 2011, at 4:13 PM, Han-Wen Nienhuys wrote: > On Fri, Jul 1, ...
12 years, 8 months ago (2011-07-13 14:27:19 UTC) #10
hanwenn
On Wed, Jul 13, 2011 at 11:27 AM, mike@apollinemike.com <mike@apollinemike.com> wrote: >> Wouldnt it be ...
12 years, 8 months ago (2011-07-13 14:42:39 UTC) #11
mike_apollinemike.com
On Jul 13, 2011, at 4:42 PM, Han-Wen Nienhuys wrote: > On Wed, Jul 13, ...
12 years, 8 months ago (2011-07-13 20:12:26 UTC) #12
hanwenn
On Wed, Jul 13, 2011 at 5:12 PM, mike@apollinemike.com <mike@apollinemike.com> wrote: > On Jul 13, ...
12 years, 8 months ago (2011-07-13 20:48:06 UTC) #13
mike_apollinemike.com
On Jul 13, 2011, at 10:48 PM, Han-Wen Nienhuys wrote: > On Wed, Jul 13, ...
12 years, 8 months ago (2011-07-14 12:27:31 UTC) #14
Carl
I like the fact that there's no more "rider" concept. The only architectural question I ...
12 years, 8 months ago (2011-07-14 12:47:12 UTC) #15
mike_apollinemike.com
On Jul 14, 2011, at 2:47 PM, Carl.D.Sorensen@gmail.com wrote: > > http://codereview.appspot.com/4639075/diff/18001/lily/axis-group-interface.cc#newcode670 > lily/axis-group-interface.cc:670: > ...
12 years, 8 months ago (2011-07-14 13:19:31 UTC) #16
hanwenn
much better. I bet there will skeletons coming out the regtest closet now, but let's ...
12 years, 8 months ago (2011-07-14 13:51:14 UTC) #17
mike_apollinemike.com
On Jul 14, 2011, at 3:51 PM, hanwenn@gmail.com wrote: > much better. I bet there ...
12 years, 8 months ago (2011-07-14 20:01:41 UTC) #18
Neil Puttock
On 14 July 2011 21:01, mike@apollinemike.com <mike@apollinemike.com> wrote: > I'll run the regtests tonight or ...
12 years, 8 months ago (2011-07-14 20:23:03 UTC) #19
MikeSol
On 2011/07/14 20:23:03, Neil Puttock wrote: > On 14 July 2011 21:01, mailto:mike@apollinemike.com <mailto:mike@apollinemike.com> wrote: ...
12 years, 8 months ago (2011-07-15 16:27:46 UTC) #20
MikeSol
12 years, 8 months ago (2011-07-28 08:29:49 UTC) #21
Pushed as 72210831b0366cb7c1f7009ba99a56538d68a7e5.

Cheers,
MS
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b