Issue 4639063: Fix possible NULL deref

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4639063: Fix possible NULL deref (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by groby

Modified:
13 years, 4 months ago

Reviewers:
vandebo (gmail), brian2

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Fix possible NULL deref CID=16637

Patch Set 1 #

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	gpu/src/GrDrawTarget.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

brian2

On 2011/06/21 23:49:07, groby wrote: > Please review Ugh, that was supposed to be target->saveCurrentDrawState(&fDrawState); ...

13 years, 4 months ago (2011-06-22 01:28:52 UTC) #2

groby

Ah, thanks! So should I close my issue, or delete it? On 2011/06/22 01:28:52, brian2 ...

13 years, 4 months ago (2011-06-22 01:34:06 UTC) #3

brian2

13 years, 4 months ago (2011-06-22 01:39:15 UTC) #4

NP, sorry for the bug! :) I think closing it is fine.

On 2011/06/22 01:34:06, groby wrote:
> Ah, thanks!
> So should I close my issue, or delete it?
> 
> 
> On 2011/06/22 01:28:52, brian2 wrote:
> > On 2011/06/21 23:49:07, groby wrote:
> > > Please review
> > 
> > Ugh, that was supposed to be             
> > 
> >     target->saveCurrentDrawState(&fDrawState);
> > not
> >     fDrawTarget->saveCurrentDrawState(&fDrawState);
> > 
> > inside the if.
> > 
> > Fixed at r1670.

Expand All Messages | Collapse All Messages