Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(169)

Issue 4639060: SampleApp cleanup. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 5 months ago by Scroggo
Modified:
13 years, 5 months ago
Reviewers:
DerekS, reed1
CC:
Leon
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

SampleApp fixes. On Android, delete gWindow before calling application_term, avoiding a crash each time the app closes. Also make sure the screen is redrawn when resuming. On Linux, delete gWindow to avoid memory leak. In general, allow moving from sample 0 to the last sample.

Patch Set 1 #

Patch Set 2 : Changed postInvalDelay to a member function. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -7 lines) Patch
M android_sample/SampleApp/jni/sample-jni.cpp View 1 4 chunks +10 lines, -2 lines 0 comments Download
M android_sample/SampleApp/src/com/skia/sampleapp/SampleApp.java View 2 chunks +11 lines, -0 lines 0 comments Download
M android_sample/SampleApp/src/com/skia/sampleapp/SampleView.java View 1 chunk +9 lines, -0 lines 0 comments Download
M samplecode/SampleApp.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M samplecode/SampleApp.cpp View 1 4 chunks +5 lines, -5 lines 0 comments Download
M unix_test_app/main.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6
Scroggo
13 years, 5 months ago (2011-06-21 15:17:40 UTC) #1
reed1
If we're going to export postInvalDelay(), lets scope the name better: 1. SampleWindow::PostInvalDelay() -- static ...
13 years, 5 months ago (2011-06-21 15:28:17 UTC) #2
scroggo_gmail.com
How about SampleWindow::postInvalDelay() - public instance method: { SkEvent* evt = new SkEvent(view_inval_msg); evt->post(this->getSinkID(), 1); ...
13 years, 5 months ago (2011-06-21 15:33:03 UTC) #3
reed1
Sure, if the caller has access to the actual instance, this is even better. On ...
13 years, 5 months ago (2011-06-21 15:36:24 UTC) #4
Scroggo
Done.
13 years, 5 months ago (2011-06-21 15:52:29 UTC) #5
reed1
13 years, 5 months ago (2011-06-21 15:59:08 UTC) #6
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b