Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(417)

Issue 4638052: Add PDF generation to SampleApp. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years ago by Scroggo
Modified:
13 years ago
Reviewers:
DerekS, reed1
CC:
Leon
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Add a way to save to PDF in SampleApp on Android and elsewhere. In Android, add the PDF file to downloads, so it can be opened.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+198 lines, -39 lines) Patch
M android_sample/SampleApp/Android.mk View 2 chunks +13 lines, -0 lines 0 comments Download
M android_sample/SampleApp/AndroidManifest.xml View 1 chunk +4 lines, -0 lines 0 comments Download
M android_sample/SampleApp/jni/sample-jni.cpp View 5 chunks +30 lines, -0 lines 0 comments Download
M android_sample/SampleApp/res/menu/sample.xml View 1 chunk +4 lines, -3 lines 0 comments Download
M android_sample/SampleApp/res/values/strings.xml View 1 chunk +4 lines, -1 line 0 comments Download
M android_sample/SampleApp/src/com/skia/sampleapp/SampleApp.java View 7 chunks +43 lines, -0 lines 0 comments Download
M gyp/SampleApp.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M include/views/SkOSWindow_Android.h View 1 chunk +3 lines, -0 lines 0 comments Download
M include/views/SkWindow.h View 1 chunk +2 lines, -0 lines 0 comments Download
M samplecode/SampleApp.h View 2 chunks +4 lines, -0 lines 0 comments Download
M samplecode/SampleApp.cpp View 8 chunks +90 lines, -35 lines 2 comments Download

Messages

Total messages: 4
Scroggo
13 years ago (2011-06-21 13:36:04 UTC) #1
DerekS
http://codereview.appspot.com/4638052/diff/1/samplecode/SampleApp.cpp File samplecode/SampleApp.cpp (right): http://codereview.appspot.com/4638052/diff/1/samplecode/SampleApp.cpp#newcode1060 samplecode/SampleApp.cpp:1060: case 'e': Why 'e'? Something like 'p' would seem ...
13 years ago (2011-06-21 14:33:27 UTC) #2
Scroggo
http://codereview.appspot.com/4638052/diff/1/samplecode/SampleApp.cpp File samplecode/SampleApp.cpp (right): http://codereview.appspot.com/4638052/diff/1/samplecode/SampleApp.cpp#newcode1060 samplecode/SampleApp.cpp:1060: case 'e': On 2011/06/21 14:33:27, djsollen wrote: > Why ...
13 years ago (2011-06-21 14:36:15 UTC) #3
DerekS
13 years ago (2011-06-21 14:38:16 UTC) #4
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b