Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1298)

Issue 4636078: merge of SkiOSSampleApp into SampleApp, still a work in progress (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 5 months ago by epoger
Modified:
13 years, 5 months ago
Reviewers:
yangsu
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Now that we have skia_os, we can merge the iOS sampleapp into SampleApp.gyp. Here's a stab at it... the project is generated, but it generates plenty of errors when you try to build it. I think we might as well commit this and then you can fix it up... Here's how to generate the XCode project (must be run on a Mac): cd trunk make clean GYP_DEFINES="skia_os=ios" ./gyp_skia

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -1 line) Patch
A experimental/iOSSampleApp/SkiOSSampleApp-Base.xcconfig View 1 chunk +16 lines, -0 lines 0 comments Download
A experimental/iOSSampleApp/SkiOSSampleApp-Debug.xcconfig View 1 chunk +11 lines, -0 lines 0 comments Download
A experimental/iOSSampleApp/SkiOSSampleApp-Release.xcconfig View 1 chunk +10 lines, -0 lines 0 comments Download
M gyp/SampleApp.gyp View 3 chunks +43 lines, -1 line 0 comments Download
M gyp/common.gypi View 1 chunk +19 lines, -0 lines 0 comments Download
M gyp/core.gyp View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 3
epoger
13 years, 5 months ago (2011-07-01 20:56:39 UTC) #1
yangsu
LGTM On 2011/07/01 20:56:39, epoger wrote:
13 years, 5 months ago (2011-07-01 21:00:52 UTC) #2
epoger
13 years, 5 months ago (2011-07-01 21:01:55 UTC) #3
committed as r1785
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b