Issue 4635066: result count function updated

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4635066: result count function updated

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 10 months ago by sinha

Modified:
13 years, 10 months ago

Reviewers:
Reimar Bauer

Visibility:
Public.

Patch Set 1 #

Total comments: 2

Created: 13 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -7 lines)			Patch
	M	MoinMoin/apps/frontend/views.py	View		2 chunks	+2 lines, -5 lines	1 comment	Download
	M	MoinMoin/user.py	View		1 chunk	+2 lines, -2 lines	1 comment	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

Reimar Bauer

13 years, 10 months ago (2011-06-24 08:21:10 UTC) #1

don't introduce two names for the same thing

http://codereview.appspot.com/4635066/diff/1/MoinMoin/apps/frontend/views.py
File MoinMoin/apps/frontend/views.py (right):

http://codereview.appspot.com/4635066/diff/1/MoinMoin/apps/frontend/views.py#...
MoinMoin/apps/frontend/views.py:554: count =
flaskg.user.getCount(default_count=count)
you introduce two words for the same thing

http://codereview.appspot.com/4635066/diff/1/MoinMoin/user.py
File MoinMoin/user.py (right):

http://codereview.appspot.com/4635066/diff/1/MoinMoin/user.py#newcode795
MoinMoin/user.py:795: def getCount(self, default_count=0):
if it is the results_per_page count then you should
use that name,

The current one has a prefix default_. You can mention yourself that everything
somehow which initialize something
is a default value for somenthing. So that prefix is unnecessary.

Expand All Messages | Collapse All Messages