Added option to set results count by logged in users

[Reimar Bauer, 2011-06-21 22:17:24]

Issues: 1) when i try to add the form element in my history template using macro
defined in forms.html,

I guess you don't have an import {% import "forms.html" as forms %} ?

At least I don't see it in the diffs.


Issues: 2) For the default count, in case of user hasn't set it or not logged
in, we can keep a attribute in wikiconfig.py, where any wiki admin could alter
that. 

Yes, default should be set in config.

The text

Show (approx) [  ] (results per page)


Without the () it is better readable,

http://codereview.appspot.com/4633059/diff/1/MoinMoin/apps/frontend/views.py
File MoinMoin/apps/frontend/views.py (left):

http://codereview.appspot.com/4633059/diff/1/MoinMoin/apps/frontend/views.py#...
MoinMoin/apps/frontend/views.py:1340: 
Please move this into +usersettings/ui
(UserSettingsUIForm) that it gets into the url below that.

http://codereview.appspot.com/4633059/diff/1/MoinMoin/templates/global_histor...
File MoinMoin/templates/global_history.html (left):

http://codereview.appspot.com/4633059/diff/1/MoinMoin/templates/global_histor...
MoinMoin/templates/global_history.html:17: </div>
I guess you don't have an import ?

{% import "forms.html" as forms %}

http://codereview.appspot.com/4633059/diff/1/MoinMoin/templates/global_histor...
File MoinMoin/templates/global_history.html (right):

http://codereview.appspot.com/4633059/diff/1/MoinMoin/templates/global_histor...
MoinMoin/templates/global_history.html:29: <form  method="get" action={{
url_for('frontend.count') }}>
blank too much

http://codereview.appspot.com/4633059/diff/1/MoinMoin/user.py
File MoinMoin/user.py (right):

http://codereview.appspot.com/4633059/diff/1/MoinMoin/user.py#newcode799
MoinMoin/user.py:799: :param count: int
explain for what that paramter is. Give not only the type for it

[Reimar Bauer, 2011-06-22 09:23:59]

i am in a talk about awesome web apps

i look later again, looks so far good

http://codereview.appspot.com/4633059/diff/4001/wikiconfig.py
File wikiconfig.py (right):

http://codereview.appspot.com/4633059/diff/4001/wikiconfig.py#newcode52
wikiconfig.py:52: result_count = 50 # default value for the number of results
per page in displaying the history of items
move that to config, so one can overwrite its value
the wikiconfig is just one example how to use all those
parametets

[Reimar Bauer, 2011-06-22 14:41:57]

just about the (50) which is now configurable

http://codereview.appspot.com/4633059/diff/4001/MoinMoin/apps/frontend/views.py
File MoinMoin/apps/frontend/views.py (right):

http://codereview.appspot.com/4633059/diff/4001/MoinMoin/apps/frontend/views....
MoinMoin/apps/frontend/views.py:1259: result_count =
Integer.using(label=L_('History results per page'),
optional=True).with_properties(placeholder=L_("History result count (default is
50)")).validated_by(ValueAtLeast(1))
this 50 is flexible so don't write it explicity here

[Reimar Bauer, 2011-06-22 14:42:00]

just about the (50) which is now configurable

[Reimar Bauer, 2011-06-26 08:02:43]

small fixes needed

http://codereview.appspot.com/4633059/diff/13002/MoinMoin/apps/frontend/views.py
File MoinMoin/apps/frontend/views.py (right):

http://codereview.appspot.com/4633059/diff/13002/MoinMoin/apps/frontend/views...
MoinMoin/apps/frontend/views.py:587: results_per_page =
flaskg.user.results_per_page # if its 0, means no paging
you mean it's for "it is"
its has a different meaning

http://codereview.appspot.com/4633059/diff/13002/MoinMoin/apps/frontend/views...
MoinMoin/apps/frontend/views.py:677: offset = 0
offset = max(int(offset), 0) ?