Issue 4633058: Handle possibly NULL deref in comparison

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by groby

Modified:
13 years, 4 months ago

Reviewers:
Steve VanDeBogart

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Handle possibly NULL deref in comparison CID=16790,16789 BUG=none TEST=none

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	src/core/SkClipStack.cpp	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Total messages: 3

Steve VanDeBogart

On 2011/06/21 18:46:52, groby wrote: > Please review LGTM. I will commit.

13 years, 4 months ago (2011-06-21 20:42:02 UTC) #2

Steve VanDeBogart

13 years, 4 months ago (2011-06-21 20:46:22 UTC) #3

Committed: http://code.google.com/p/skia/source/detail?r=1666