Issue 4632044: split SkDevice construct into offscreen and direct versions

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4632044: split SkDevice construct into offscreen and direct versions (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by reed1

Modified:
12 years, 12 months ago

Reviewers:
bsalomon

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Created: 13 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+189 lines, -119 lines)			Patch
M	bench/benchmain.cpp	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download
M	gm/gmmain.cpp	View	1 2 3 4	1 chunk	+9 lines, -8 lines	0 comments	Download
M	include/core/SkCanvas.h	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	include/core/SkDevice.h	View	1 2	2 chunks	+22 lines, -11 lines	0 comments	Download
M	include/gpu/SkGpuDevice.h	View	1 2	2 chunks	+13 lines, -8 lines	0 comments	Download
M	include/utils/SkProxyCanvas.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	samplecode/SampleApp.cpp	View	1 2	2 chunks	+2 lines, -3 lines	0 comments	Download
M	samplecode/SampleTextureDomain.cpp	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	src/core/SkCanvas.cpp	View	1 2	4 chunks	+6 lines, -6 lines	0 comments	Download
M	src/core/SkDevice.cpp	View	1 2	2 chunks	+28 lines, -18 lines	0 comments	Download
M	src/gpu/SkGpuDevice.cpp	View	1 2	3 chunks	+98 lines, -51 lines	0 comments	Download
M	src/pdf/SkPDFDevice.cpp	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/utils/SkProxyCanvas.cpp	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/views/SkWindow.cpp	View	1 2	1 chunk	+1 line, -4 lines	0 comments	Download

Total messages: 2

On 2011/06/16 17:58:54, reed1 wrote:

LGTM