Change in item index view

Please see diary page http://moinmo.in/AkashSinha/Gsoc2011Diary/2011-07-07 for screen shot.

[Reimar Bauer, 2011-07-07 17:32:01]

some comments, thoughts

http://codereview.appspot.com/4631094/diff/1/MoinMoin/apps/frontend/views.py
File MoinMoin/apps/frontend/views.py (right):

http://codereview.appspot.com/4631094/diff/1/MoinMoin/apps/frontend/views.py#...
MoinMoin/apps/frontend/views.py:483: test_item = item.create(fullname)
I know the functionality is for testing that. but i dislike those names, find a
better one

http://codereview.appspot.com/4631094/diff/1/MoinMoin/apps/frontend/views.py#...
MoinMoin/apps/frontend/views.py:486: if item_index:
in your case an item needs only one subitem to get hassubitem valid. So there is
no need for this case to get all subitems with flat_index.

May be it can be faster to have just a list of all names and check for parent
names which have chields by re.

parent_item_name = wikiutil.ParentItemName(item_name)
gets the name of the parent too

[sinha, 2011-07-08 02:07:40]

Code to get the subitem flag has been modified.
I just needed to get sure that this code will work for all kind of unicode
names, if it doesn't then what changes should i make ?

 If this code is fine, then should i create a function for this in
items/__init__.py file, which could be called from both the index and
global_index function.

[Reimar Bauer, 2011-07-08 06:27:05]

comment about renaming a var

http://codereview.appspot.com/4631094/diff/4001/MoinMoin/apps/frontend/views.py
File MoinMoin/apps/frontend/views.py (right):

http://codereview.appspot.com/4631094/diff/4001/MoinMoin/apps/frontend/views....
MoinMoin/apps/frontend/views.py:486: item_name_re = u"%s/" % re.escape(relname)
it is sub_item_name_re 

because the item_name_re does not require to endwith '/' ;)

[Reimar Bauer, 2011-07-08 12:30:33]

unit test wanted!

some naming probs

http://codereview.appspot.com/4631094/diff/3002/MoinMoin/items/__init__.py
File MoinMoin/items/__init__.py (right):

http://codereview.appspot.com/4631094/diff/3002/MoinMoin/items/__init__.py#ne...
MoinMoin/items/__init__.py:593: 
Please add a unittest to the module for testing items for this method.

http://codereview.appspot.com/4631094/diff/3002/MoinMoin/items/__init__.py#ne...
MoinMoin/items/__init__.py:595: detailed_index = []
you overwrite the method name with a list definition.

http://codereview.appspot.com/4631094/diff/3002/MoinMoin/items/__init__.py#ne...
MoinMoin/items/__init__.py:595: detailed_index = []
add docstring to the method

describe which index that is

http://codereview.appspot.com/4631094/diff/3002/MoinMoin/items/__init__.py#ne...
MoinMoin/items/__init__.py:603: hassubitem = True
indenting

[Reimar Bauer, 2011-07-08 16:57:19]

just seen that doc string wich is not a good one

fix this and commit it

http://codereview.appspot.com/4631094/diff/13001/MoinMoin/items/__init__.py
File MoinMoin/items/__init__.py (right):

http://codereview.appspot.com/4631094/diff/13001/MoinMoin/items/__init__.py#n...
MoinMoin/items/__init__.py:595: """ appends a hassubitem flag in the index of
items  """
that reads strange
may be 

appends a flag in the index of items indicating the parent has sub items