Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4811)

Issue 4631094: Change in item index view

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 4 months ago by sinha
Modified:
13 years, 4 months ago
Visibility:
Public.

Description

Please see diary page http://moinmo.in/AkashSinha/Gsoc2011Diary/2011-07-07 for screen shot.

Patch Set 1 #

Total comments: 2

Patch Set 2 : code to get the subitem flag has bene updated #

Total comments: 1

Patch Set 3 : code refactored for that subitems flagging #

Total comments: 4

Patch Set 4 : unittest and docstring added for get_detailed_index function #

Patch Set 5 : unittest for get_detailed_index() function modified #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -13 lines) Patch
M MoinMoin/apps/frontend/views.py View 1 2 3 1 chunk +3 lines, -12 lines 0 comments Download
M MoinMoin/items/__init__.py View 1 2 3 4 1 chunk +14 lines, -0 lines 1 comment Download
M MoinMoin/items/_tests/test_Item.py View 1 2 3 4 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 5
Reimar Bauer
some comments, thoughts http://codereview.appspot.com/4631094/diff/1/MoinMoin/apps/frontend/views.py File MoinMoin/apps/frontend/views.py (right): http://codereview.appspot.com/4631094/diff/1/MoinMoin/apps/frontend/views.py#newcode483 MoinMoin/apps/frontend/views.py:483: test_item = item.create(fullname) I know the ...
13 years, 4 months ago (2011-07-07 17:32:01 UTC) #1
sinha
Code to get the subitem flag has been modified. I just needed to get sure ...
13 years, 4 months ago (2011-07-08 02:07:40 UTC) #2
Reimar Bauer
comment about renaming a var http://codereview.appspot.com/4631094/diff/4001/MoinMoin/apps/frontend/views.py File MoinMoin/apps/frontend/views.py (right): http://codereview.appspot.com/4631094/diff/4001/MoinMoin/apps/frontend/views.py#newcode486 MoinMoin/apps/frontend/views.py:486: item_name_re = u"%s/" % ...
13 years, 4 months ago (2011-07-08 06:27:05 UTC) #3
Reimar Bauer
unit test wanted! some naming probs http://codereview.appspot.com/4631094/diff/3002/MoinMoin/items/__init__.py File MoinMoin/items/__init__.py (right): http://codereview.appspot.com/4631094/diff/3002/MoinMoin/items/__init__.py#newcode593 MoinMoin/items/__init__.py:593: Please add a ...
13 years, 4 months ago (2011-07-08 12:30:33 UTC) #4
Reimar Bauer
13 years, 4 months ago (2011-07-08 16:57:19 UTC) #5
just seen that doc string wich is not a good one

fix this and commit it

http://codereview.appspot.com/4631094/diff/13001/MoinMoin/items/__init__.py
File MoinMoin/items/__init__.py (right):

http://codereview.appspot.com/4631094/diff/13001/MoinMoin/items/__init__.py#n...
MoinMoin/items/__init__.py:595: """ appends a hassubitem flag in the index of
items  """
that reads strange
may be 

appends a flag in the index of items indicating the parent has sub items
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b