Issue 4631082: code review 4631082: goprotobuf: Revert part of 39eef1b13365.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4631082: code review 4631082: goprotobuf: Revert part of 39eef1b13365. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 11 months ago by dsymonds

Modified:
14 years, 11 months ago

Reviewers:

CC:
adg, golang-dev

Visibility:
Public.

Description

goprotobuf: Revert part of 39eef1b13365. This gets goprotobuf working with release.r58. After tagging, I'll revert this change.

Patch Set 1 #

Patch Set 2 : diff -r 97d694cc53c9 https://goprotobuf.googlecode.com/hg #

Patch Set 3 : diff -r 97d694cc53c9 https://goprotobuf.googlecode.com/hg #

Patch Set 4 : diff -r 97d694cc53c9 https://goprotobuf.googlecode.com/hg #

Created: 14 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	proto/properties.go	View	1	3 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dsymonds

Hello adg (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://goprotobuf.googlecode.com/hg

14 years, 11 months ago (2011-07-01 01:14:54 UTC) #1

dsymonds

*** Submitted as http://code.google.com/p/goprotobuf/source/detail?r=cfe37a63cede *** goprotobuf: Revert part of 39eef1b13365. This gets goprotobuf working with ...

14 years, 11 months ago (2011-07-01 01:23:06 UTC) #2

LGTM

Expand All Messages | Collapse All Messages