Add a zlib target that the pdf target can depend on.

Add a zlib target that the pdf target can depend on.

- make drawTextOnPath (now used by shadertext) a non fatal NOT_IMPLEMENTED on PDF.

Committed: http://code.google.com/p/skia/source/detail?r=1722

[epoger, 2011-06-24 21:00:29]

just one concern...

http://codereview.appspot.com/4631071/diff/1/gyp/zlib.gyp
File gyp/zlib.gyp (right):

http://codereview.appspot.com/4631071/diff/1/gyp/zlib.gyp#newcode25
gyp/zlib.gyp:25: }, { # OS != "mac"
Looks to me like this would break on Windows.  Can you try it there before
committing?

[Steve VanDeBogart, 2011-06-24 21:10:36]

http://codereview.appspot.com/4631071/diff/1/gyp/zlib.gyp
File gyp/zlib.gyp (right):

http://codereview.appspot.com/4631071/diff/1/gyp/zlib.gyp#newcode25
gyp/zlib.gyp:25: }, { # OS != "mac"
On 2011/06/24 21:00:29, epoger wrote:
> Looks to me like this would break on Windows.  Can you try it there before
> committing?

Is windows supposed to work?  I tried it yesterday (and again just now) and
gyp_skia barfs like this:


Traceback (most recent call last):
  File "./gyp_skia", line 90, in <module>
    sys.exit(gyp.main(args))
  File "./third_party/externals/gyp/pylib/gyp/__init__.py", line 454, in main
    generator.GenerateOutput(flat_list, targets, data, params)
  File "./third_party/externals/gyp/pylib/gyp/generator/msvs.py", line 1650, in
GenerateOutput
    _GenerateProject(project, options, msvs_version)
  File "./third_party/externals/gyp/pylib/gyp/generator/msvs.py", line 839, in
_GenerateProject
    _GenerateMSVSProject(project, options, version)
  File "./third_party/externals/gyp/pylib/gyp/generator/msvs.py", line 899, in
_GenerateMSVSProject
    p.Write()
  File "./third_party/externals/gyp/pylib/gyp/MSVSProject.py", line 239, in
Write
    f = writer(self.project_path)
  File "./third_party/externals/gyp/pylib/gyp/common.py", line 326, in
WriteOnDiff
    return Writer()
  File "./third_party/externals/gyp/pylib/gyp/common.py", line 273, in __init__
    dir=os.path.split(filename)[0])
  File "/usr/lib/python2.6/tempfile.py", line 293, in mkstemp
    return _mkstemp_inner(dir, prefix, suffix, flags)
  File "/usr/lib/python2.6/tempfile.py", line 228, in _mkstemp_inner
    fd = _os.open(file, flags, 0600)
OSError: [Errno 2] No such file or directory:
'\\cygdrive\\d\\src\\skia\\out\\gyp\\experimental.vcproj.gyp.UWG6Vv.tmp'


\\cygdrive\\d\\src\\skia\\out\\gyp\\ exists and is empty.

[epoger, 2011-06-24 21:20:29]

On Fri, Jun 24, 2011 at 5:10 PM, <vandebo@chromium.org> wrote:

>
>
http://codereview.appspot.com/**4631071/diff/1/gyp/zlib.gyp<http://codereview...
> File gyp/zlib.gyp (right):
>
>
http://codereview.appspot.com/**4631071/diff/1/gyp/zlib.gyp#**newcode25<http:...
> gyp/zlib.gyp:25: }, { # OS != "mac"
> On 2011/06/24 21:00:29, epoger wrote:
>
>> Looks to me like this would break on Windows.  Can you try it there
>>
> before
>
>> committing?
>>
>
> Is windows supposed to work?


Yes, windows is supposed to work, as documented at
http://code.google.com/p/skia/wiki/GettingStartedOnWindows

I haven't tried it lately, and we don't have a buildbot running on Windows,
so I don't know the current state.  But it looks like it's failing for you
because you are building within cygwin, not using the instructions at the
link above.

If you are unable to test it on Windows, please change the gyp file to just
change nothing on Windows, and I can add the Windows support on Monday...

 I tried it yesterday (and again just now)
> and gyp_skia barfs like this:
>
>
> Traceback (most recent call last):
>  File "./gyp_skia", line 90, in <module>
>    sys.exit(gyp.main(args))
>  File "./third_party/externals/gyp/**pylib/gyp/__init__.py", line 454, in
> main
>    generator.GenerateOutput(flat_**list, targets, data, params)
>  File "./third_party/externals/gyp/**pylib/gyp/generator/msvs.py", line
> 1650, in GenerateOutput
>    _GenerateProject(project, options, msvs_version)
>  File "./third_party/externals/gyp/**pylib/gyp/generator/msvs.py", line
> 839, in _GenerateProject
>    _GenerateMSVSProject(project, options, version)
>  File "./third_party/externals/gyp/**pylib/gyp/generator/msvs.py", line
> 899, in _GenerateMSVSProject
>    p.Write()
>  File "./third_party/externals/gyp/**pylib/gyp/MSVSProject.py", line 239,
> in Write
>    f = writer(self.project_path)
>  File "./third_party/externals/gyp/**pylib/gyp/common.py", line 326, in
> WriteOnDiff
>    return Writer()
>  File "./third_party/externals/gyp/**pylib/gyp/common.py", line 273, in
> __init__
>    dir=os.path.split(filename)[0]**)
>  File "/usr/lib/python2.6/tempfile.**py", line 293, in mkstemp
>    return _mkstemp_inner(dir, prefix, suffix, flags)
>  File "/usr/lib/python2.6/tempfile.**py", line 228, in _mkstemp_inner
>    fd = _os.open(file, flags, 0600)
> OSError: [Errno 2] No such file or directory:
> '\\cygdrive\\d\\src\\skia\\**out\\gyp\\experimental.vcproj.**
> gyp.UWG6Vv.tmp'
>
>
> \\cygdrive\\d\\src\\skia\\out\**\gyp\\ exists and is empty.
>
>
>
http://codereview.appspot.com/**4631071/<http://codereview.appspot.com/4631071/>
>

[Steve VanDeBogart, 2011-06-24 21:22:33]

On Fri, Jun 24, 2011 at 2:19 PM, Elliot Poger <epoger@google.com> wrote:

>
>
> On Fri, Jun 24, 2011 at 5:10 PM, <vandebo@chromium.org> wrote:
>
>>
>>
http://codereview.appspot.com/**4631071/diff/1/gyp/zlib.gyp<http://codereview...
>> File gyp/zlib.gyp (right):
>>
>>
http://codereview.appspot.com/**4631071/diff/1/gyp/zlib.gyp#**newcode25<http:...
>> gyp/zlib.gyp:25: }, { # OS != "mac"
>> On 2011/06/24 21:00:29, epoger wrote:
>>
>>> Looks to me like this would break on Windows.  Can you try it there
>>>
>> before
>>
>>> committing?
>>>
>>
>> Is windows supposed to work?
>
>
> Yes, windows is supposed to work, as documented at
> http://code.google.com/p/skia/wiki/GettingStartedOnWindows
>
> I haven't tried it lately, and we don't have a buildbot running on Windows,
> so I don't know the current state.  But it looks like it's failing for you
> because you are building within cygwin, not using the instructions at the
> link above.
>

Do you know why it doesn't work under cygwin?  It does for Chrome.



>
> If you are unable to test it on Windows, please change the gyp file to just
> change nothing on Windows, and I can add the Windows support on Monday...
>
>   I tried it yesterday (and again just now)
>> and gyp_skia barfs like this:
>>
>>
>> Traceback (most recent call last):
>>  File "./gyp_skia", line 90, in <module>
>>    sys.exit(gyp.main(args))
>>  File "./third_party/externals/gyp/**pylib/gyp/__init__.py", line 454, in
>> main
>>    generator.GenerateOutput(flat_**list, targets, data, params)
>>  File "./third_party/externals/gyp/**pylib/gyp/generator/msvs.py", line
>> 1650, in GenerateOutput
>>    _GenerateProject(project, options, msvs_version)
>>  File "./third_party/externals/gyp/**pylib/gyp/generator/msvs.py", line
>> 839, in _GenerateProject
>>    _GenerateMSVSProject(project, options, version)
>>  File "./third_party/externals/gyp/**pylib/gyp/generator/msvs.py", line
>> 899, in _GenerateMSVSProject
>>    p.Write()
>>  File "./third_party/externals/gyp/**pylib/gyp/MSVSProject.py", line 239,
>> in Write
>>    f = writer(self.project_path)
>>  File "./third_party/externals/gyp/**pylib/gyp/common.py", line 326, in
>> WriteOnDiff
>>    return Writer()
>>  File "./third_party/externals/gyp/**pylib/gyp/common.py", line 273, in
>> __init__
>>    dir=os.path.split(filename)[0]**)
>>  File "/usr/lib/python2.6/tempfile.**py", line 293, in mkstemp
>>    return _mkstemp_inner(dir, prefix, suffix, flags)
>>  File "/usr/lib/python2.6/tempfile.**py", line 228, in _mkstemp_inner
>>    fd = _os.open(file, flags, 0600)
>> OSError: [Errno 2] No such file or directory:
>> '\\cygdrive\\d\\src\\skia\\**out\\gyp\\experimental.vcproj.**
>> gyp.UWG6Vv.tmp'
>>
>>
>> \\cygdrive\\d\\src\\skia\\out\**\gyp\\ exists and is empty.
>>
>>
>>
http://codereview.appspot.com/**4631071/<http://codereview.appspot.com/4631071/>
>>
>
>  --
> You received this message because you are subscribed to the Google Groups
> "skia-review" group.
> To post to this group, send email to skia-review@googlegroups.com.
> To unsubscribe from this group, send email to
> skia-review+unsubscribe@googlegroups.com.
> For more options, visit this group at
> http://groups.google.com/group/skia-review?hl=en.
>

[Steve VanDeBogart, 2011-06-24 21:42:38]

Changed to not break windows.

[epoger, 2011-06-24 21:49:17]

LGTM