Issue 4631061: Allow override of skia_scalar gyp variable using GYP_DEFINES

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4631061: Allow override of skia_scalar gyp variable using GYP_DEFINES (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by epoger

Modified:
13 years, 5 months ago

Reviewers:
bungeman

CC:
caryclark1, skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Description

This allows the developer to override skia_scalar within a single command line, while using the new toplevel redirecting Makefile... # build gm using skia_scalar=float (default) make gm # build gm using skia_scalar=fixed GYP_DEFINES="skia_scalar=fixed" make gm

Patch Set 1 #

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	gyp/target_defaults.gypi	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bungeman

LGTM A Gyp Haiku Gyp is wonderful. Much undocumented stuff. Put it on the wiki.

13 years, 5 months ago (2011-06-22 21:20:19 UTC) #2

committed as r1689

Expand All Messages | Collapse All Messages