Issue 4630062: Wrap SkStreams in IStreams instead of copying data around.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4630062: Wrap SkStreams in IStreams instead of copying data around. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by bungeman

Modified:
13 years, 3 months ago

Reviewers:
epoger, reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+583 lines, -184 lines)			Patch
M	gyp/images.gyp	View	1 2 3	1 chunk	+3 lines, -0 lines	0 comments	Download
M	gyp/utils.gyp	View	1 2 3	3 chunks	+44 lines, -23 lines	0 comments	Download
A	include/utils/win/SkAutoCoInitialize.h	View	1 2 3	1 chunk	+37 lines, -0 lines	0 comments	Download
A	include/utils/win/SkIStream.h	View	1 2 3	1 chunk	+135 lines, -0 lines	0 comments	Download
A	include/utils/win/SkTScopedComPtr.h	View	1 2	1 chunk	+47 lines, -0 lines	0 comments	Download
M	src/ports/SkImageDecoder_WIC.cpp	View	1 2 3	11 chunks	+20 lines, -161 lines	0 comments	Download
A	src/utils/win/SkAutoCoInitialize.cpp	View	1 2 3	1 chunk	+34 lines, -0 lines	0 comments	Download
A	src/utils/win/SkIStream.cpp	View	1 2	1 chunk	+263 lines, -0 lines	0 comments	Download

Total messages: 7

reed1

Does it make sense to pull SkIStream and SkWIStream out to utils/win as stand-alone helpers?

13 years, 3 months ago (2011-06-23 17:13:04 UTC) #2

bungeman

On 2011/06/23 17:13:04, reed1 wrote: > Does it make sense to pull SkIStream and SkWIStream ...

13 years, 3 months ago (2011-06-23 17:29:03 UTC) #3

bungeman

Split out IStream wrappers from SkImageDecoder_WIC. Since we now have IStreams exposed, scoped_com_ptr was also ...

13 years, 3 months ago (2011-06-23 20:33:40 UTC) #4

Committed revision 1694.