Issue 4630055: Fix a batch of coverity defects, uninitialized class fields.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4630055: Fix a batch of coverity defects, uninitialized class fields. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 6 months ago by Steve VanDeBogart

Modified:
13 years, 6 months ago

Reviewers:
Chris Guillory

CC:
skia-review_googlegroups.com, reed1

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

Description

Fix a batch of coverity defects, uninitialized class fields. In SkClipStack::B2FIter::Clip, SkWriter32, SkClipStack::Rec, SkDeque::F2BIter, SkPDFShader::State CID 15427,15433,15533,15532,16274,16740 Committed: http://code.google.com/p/skia/source/detail?r=1669

Patch Set 1 #

Created: 13 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -10 lines)			Patch
M	include/core/SkClipStack.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	include/core/SkWriter32.h	View	1 chunk	+7 lines, -5 lines	0 comments	Download
M	src/core/SkClipStack.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/core/SkDeque.cpp	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	src/pdf/SkPDFShader.cpp	View	1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM.

Expand All Messages | Collapse All Messages