Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2164)

Issue 4629088: Remove GrAuto*Malloc, replace with SkAuto*Malloc (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 5 months ago by bsalomon
Modified:
13 years, 5 months ago
Reviewers:
reed1
CC:
TomH, Stephen White, skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : add some braces #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -226 lines) Patch
D gpu/include/GrMemory.h View 1 chunk +0 lines, -181 lines 0 comments Download
M gpu/src/GrAtlas.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M gpu/src/GrBufferAllocPool.h View 2 chunks +2 lines, -3 lines 0 comments Download
M gpu/src/GrBufferAllocPool.cpp View 4 chunks +2 lines, -4 lines 0 comments Download
M gpu/src/GrContext.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M gpu/src/GrGLProgram.cpp View 3 chunks +2 lines, -3 lines 0 comments Download
M gpu/src/GrGLTexture.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M gpu/src/GrGpu.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/src/GrGpuGL.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M gpu/src/GrGpuGLShaders.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/src/GrMemory.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M gpu/src/GrPathRenderer.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M gpu/src/GrTesselatedPathRenderer.cpp View 2 chunks +5 lines, -4 lines 0 comments Download
M gpu/src/GrTextStrike.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M gyp/gpu.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M include/core/SkTemplates.h View 1 1 chunk +63 lines, -11 lines 0 comments Download

Messages

Total messages: 3
bsalomon
Change related to Mike's comment on GrAutoSTMalloc http://codereview.appspot.com/4661062/ (Tesselate path once for tiled offscreen AA)
13 years, 5 months ago (2011-06-30 21:03:31 UTC) #1
reed1
Sweet. I would have just #define Gr... to Sk..., but yours is cleaner :) LGTM
13 years, 5 months ago (2011-06-30 21:09:04 UTC) #2
bsalomon
13 years, 5 months ago (2011-06-30 21:49:16 UTC) #3
closed with r1774.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b