Issue 4629073: [PATCH]: Doc: NR @knownissue for partCombine + spanners (Closed)
|
Created:
13 years, 9 months ago by pkx166h Modified:
13 years, 9 months ago CC:
lilypond-devel_gnu.org Visibility:
Public. |
DescriptionDoc: NR @knownissue for partCombine + spanners
Consolidtated some of the existing @knownissues so they aren't just a long
unreadable list. Took the opportunity to tidy up the syntax and correct some of the
examples as per the CG.
Added an @seealso that references back to autobeaming where another
@knownissue for \partcombining is referred to.
Patch Set 1 #
Total comments: 20
Patch Set 2 : Second Draft #
Total comments: 28
Patch Set 3 : Third Draft #MessagesTotal messages: 8
To address http://code.google.com/p/lilypond/issues/detail?id=1643 I realise this is slightly more than the above issue asks for :) but I hope you like the edits and it improves this section. I certainly learnt some 'stuff'. James
Sign in to reply to this message.
LGTM apart from some editorial nitpicks noted. Trevor http://codereview.appspot.com/4629073/diff/1/Documentation/notation/simultane... File Documentation/notation/simultaneous.itely (right): http://codereview.appspot.com/4629073/diff/1/Documentation/notation/simultane... Documentation/notation/simultaneous.itely:775: @code{Voice} is printed. Stem directions set up & down accordingly while Stem directions are set automatically while Solo and @notation{a due} parts are identified and marked accordingly. http://codereview.appspot.com/4629073/diff/1/Documentation/notation/simultane... Documentation/notation/simultaneous.itely:814: Even though both parts have identical notes in the third measure, only Both parts have identical notes in the third measure, so only one ... http://codereview.appspot.com/4629073/diff/1/Documentation/notation/simultane... Documentation/notation/simultaneous.itely:816: are set automatically, depending whether there is a solo or unison. depending on whether the parts are playing solo or in unison. http://codereview.appspot.com/4629073/diff/1/Documentation/notation/simultane... Documentation/notation/simultaneous.itely:824: @code{Voice} contexts, so if using @code{\relative} octaves, then so if the music is being specified in relative mode ... http://codereview.appspot.com/4629073/diff/1/Documentation/notation/simultane... Documentation/notation/simultaneous.itely:834: A @code{\relative} section that is placed outside of @code{\partcombine} section that encloses @code{\partcombine} has no ... http://codereview.appspot.com/4629073/diff/1/Documentation/notation/simultane... Documentation/notation/simultaneous.itely:854: into a chord, or showing one voice as solo is, therefore, not ideal as space http://codereview.appspot.com/4629073/diff/1/Documentation/notation/simultane... Documentation/notation/simultaneous.itely:864: @code{\partcombineApart} or @code{\partcombineApartOnce}: This keeps the I think the items in this section read better if "and" is used together with plural verbs, like this: @code{\partcombineApart} and @code{\partcombineApartOnce} keep the notes ... Similarly for the other items (not marked). http://codereview.appspot.com/4629073/diff/1/Documentation/notation/simultane... Documentation/notation/simultaneous.itely:956: started when combining notes that have just started in the other space http://codereview.appspot.com/4629073/diff/1/Documentation/notation/simultane... Documentation/notation/simultaneous.itely:957: @code{Voice}. This can lead to a number of unexpected issues including space http://codereview.appspot.com/4629073/diff/1/Documentation/notation/simultane... Documentation/notation/simultaneous.itely:966: give the voices, internally, its own custom names; @code{one} and colon
Sign in to reply to this message.
Second Draft - Thanks for the comments Trevor http://codereview.appspot.com/4629073/diff/1/Documentation/notation/simultane... File Documentation/notation/simultaneous.itely (right): http://codereview.appspot.com/4629073/diff/1/Documentation/notation/simultane... Documentation/notation/simultaneous.itely:775: @code{Voice} is printed. Stem directions set up & down accordingly while On 2011/06/26 08:58:43, Trevor Daniels wrote: > Stem directions are set automatically while Solo and @notation{a due} parts are > identified and marked accordingly. Done. Although changed one of the 'accordinly's to 'appropriately' just to make it read better. http://codereview.appspot.com/4629073/diff/1/Documentation/notation/simultane... Documentation/notation/simultaneous.itely:814: Even though both parts have identical notes in the third measure, only On 2011/06/26 08:58:43, Trevor Daniels wrote: > Both parts have identical notes in the third measure, so only one ... Done. http://codereview.appspot.com/4629073/diff/1/Documentation/notation/simultane... Documentation/notation/simultaneous.itely:816: are set automatically, depending whether there is a solo or unison. On 2011/06/26 08:58:43, Trevor Daniels wrote: > depending on whether the parts are playing solo or in unison. Done. http://codereview.appspot.com/4629073/diff/1/Documentation/notation/simultane... Documentation/notation/simultaneous.itely:824: @code{Voice} contexts, so if using @code{\relative} octaves, then On 2011/06/26 08:58:43, Trevor Daniels wrote: > so if the music is being specified in relative mode ... Done. http://codereview.appspot.com/4629073/diff/1/Documentation/notation/simultane... Documentation/notation/simultaneous.itely:834: A @code{\relative} section that is placed outside of @code{\partcombine} On 2011/06/26 08:58:43, Trevor Daniels wrote: > section that encloses @code{\partcombine} has no ... Done. http://codereview.appspot.com/4629073/diff/1/Documentation/notation/simultane... Documentation/notation/simultaneous.itely:854: into a chord, or showing one voice as solo is, therefore, not ideal as On 2011/06/26 08:58:43, Trevor Daniels wrote: > space Done. http://codereview.appspot.com/4629073/diff/1/Documentation/notation/simultane... Documentation/notation/simultaneous.itely:864: @code{\partcombineApart} or @code{\partcombineApartOnce}: This keeps the On 2011/06/26 08:58:43, Trevor Daniels wrote: > I think the items in this section read better if "and" is used together with > plural verbs, like this: > > @code{\partcombineApart} and @code{\partcombineApartOnce} keep the notes ... > > Similarly for the other items (not marked). Done. http://codereview.appspot.com/4629073/diff/1/Documentation/notation/simultane... Documentation/notation/simultaneous.itely:956: started when combining notes that have just started in the other On 2011/06/26 08:58:43, Trevor Daniels wrote: > space Done. http://codereview.appspot.com/4629073/diff/1/Documentation/notation/simultane... Documentation/notation/simultaneous.itely:957: @code{Voice}. This can lead to a number of unexpected issues including On 2011/06/26 08:58:43, Trevor Daniels wrote: > space Done. http://codereview.appspot.com/4629073/diff/1/Documentation/notation/simultane... Documentation/notation/simultaneous.itely:966: give the voices, internally, its own custom names; @code{one} and On 2011/06/26 08:58:43, Trevor Daniels wrote: > colon Done.
Sign in to reply to this message.
looks fine.
Sign in to reply to this message.
A few more nitpicking typos - some I missed first time through, some you missed when dealing with my earlier comments :) I'm happy for you to push after fixing these. Thanks! Trevor http://codereview.appspot.com/4629073/diff/1003/Documentation/notation/simult... File Documentation/notation/simultaneous.itely (right): http://codereview.appspot.com/4629073/diff/1003/Documentation/notation/simult... Documentation/notation/simultaneous.itely:775: @code{Voice} is printed. Stem directions are set up & down accordingly space http://codereview.appspot.com/4629073/diff/1003/Documentation/notation/simult... Documentation/notation/simultaneous.itely:814: Both parts have identical notes in the third measure, only one instance so only http://codereview.appspot.com/4629073/diff/1003/Documentation/notation/simult... Documentation/notation/simultaneous.itely:816: automatically, depending whether the parts are playing solo or in depending on whether http://codereview.appspot.com/4629073/diff/1003/Documentation/notation/simult... Documentation/notation/simultaneous.itely:817: unison. When needed in polyphony situations, the first part (with space http://codereview.appspot.com/4629073/diff/1003/Documentation/notation/simult... Documentation/notation/simultaneous.itely:819: @code{two}) always gets @qq{down} stems. In solo situations, the first space http://codereview.appspot.com/4629073/diff/1003/Documentation/notation/simult... Documentation/notation/simultaneous.itely:867: notes as two separate voices, even if they can be combined to a chord or into a chord http://codereview.appspot.com/4629073/diff/1003/Documentation/notation/simult... Documentation/notation/simultaneous.itely:879: @code{\partcombineSoloI} and @code{\partcombineSoloIOnce} prints only print http://codereview.appspot.com/4629073/diff/1003/Documentation/notation/simult... Documentation/notation/simultaneous.itely:880: voice one, and marks it as a @qq{Solo}. mark http://codereview.appspot.com/4629073/diff/1003/Documentation/notation/simult... Documentation/notation/simultaneous.itely:883: @code{\partcombineSoloII} or @code{\partcombineSoloIIOnce} prints only print http://codereview.appspot.com/4629073/diff/1003/Documentation/notation/simult... Documentation/notation/simultaneous.itely:884: voice two and marks it as a @qq{Solo}. mark http://codereview.appspot.com/4629073/diff/1003/Documentation/notation/simult... Documentation/notation/simultaneous.itely:888: the functions of the commands above, and reverts back to the standard revert http://codereview.appspot.com/4629073/diff/1003/Documentation/notation/simult... Documentation/notation/simultaneous.itely:954: typeset @code{a2} more than once that measure. in that measure. http://codereview.appspot.com/4629073/diff/1003/Documentation/notation/simult... Documentation/notation/simultaneous.itely:956: @code{\partcombine} only knows when a note starts in a @code{Voice}, it @code{Voice}; http://codereview.appspot.com/4629073/diff/1003/Documentation/notation/simult... Documentation/notation/simultaneous.itely:957: cannot for example, remember if a note in one @code{Voice} has already cannot, for example,
Sign in to reply to this message.
Third Draft. Thanks again Trevor. Hopefully I've corrected everything now. I'll wait until tomorrow A.M. and push it then if no one else has any suggestions. http://codereview.appspot.com/4629073/diff/1003/Documentation/notation/simult... File Documentation/notation/simultaneous.itely (right): http://codereview.appspot.com/4629073/diff/1003/Documentation/notation/simult... Documentation/notation/simultaneous.itely:775: @code{Voice} is printed. Stem directions are set up & down accordingly On 2011/06/26 22:00:52, Trevor Daniels wrote: > space Done. http://codereview.appspot.com/4629073/diff/1003/Documentation/notation/simult... Documentation/notation/simultaneous.itely:814: Both parts have identical notes in the third measure, only one instance On 2011/06/26 22:00:52, Trevor Daniels wrote: > so only Done. http://codereview.appspot.com/4629073/diff/1003/Documentation/notation/simult... Documentation/notation/simultaneous.itely:816: automatically, depending whether the parts are playing solo or in On 2011/06/26 22:00:52, Trevor Daniels wrote: > depending on whether Done. http://codereview.appspot.com/4629073/diff/1003/Documentation/notation/simult... Documentation/notation/simultaneous.itely:817: unison. When needed in polyphony situations, the first part (with On 2011/06/26 22:00:52, Trevor Daniels wrote: > space Done. http://codereview.appspot.com/4629073/diff/1003/Documentation/notation/simult... Documentation/notation/simultaneous.itely:819: @code{two}) always gets @qq{down} stems. In solo situations, the first On 2011/06/26 22:00:52, Trevor Daniels wrote: > space Done. http://codereview.appspot.com/4629073/diff/1003/Documentation/notation/simult... Documentation/notation/simultaneous.itely:867: notes as two separate voices, even if they can be combined to a chord or On 2011/06/26 22:00:52, Trevor Daniels wrote: > into a chord Done. http://codereview.appspot.com/4629073/diff/1003/Documentation/notation/simult... Documentation/notation/simultaneous.itely:879: @code{\partcombineSoloI} and @code{\partcombineSoloIOnce} prints only On 2011/06/26 22:00:52, Trevor Daniels wrote: > print Done. http://codereview.appspot.com/4629073/diff/1003/Documentation/notation/simult... Documentation/notation/simultaneous.itely:880: voice one, and marks it as a @qq{Solo}. On 2011/06/26 22:00:52, Trevor Daniels wrote: > mark Done. http://codereview.appspot.com/4629073/diff/1003/Documentation/notation/simult... Documentation/notation/simultaneous.itely:883: @code{\partcombineSoloII} or @code{\partcombineSoloIIOnce} prints only On 2011/06/26 22:00:52, Trevor Daniels wrote: > print Done. http://codereview.appspot.com/4629073/diff/1003/Documentation/notation/simult... Documentation/notation/simultaneous.itely:884: voice two and marks it as a @qq{Solo}. On 2011/06/26 22:00:52, Trevor Daniels wrote: > mark Done. http://codereview.appspot.com/4629073/diff/1003/Documentation/notation/simult... Documentation/notation/simultaneous.itely:888: the functions of the commands above, and reverts back to the standard On 2011/06/26 22:00:52, Trevor Daniels wrote: > revert Done. http://codereview.appspot.com/4629073/diff/1003/Documentation/notation/simult... Documentation/notation/simultaneous.itely:954: typeset @code{a2} more than once that measure. On 2011/06/26 22:00:52, Trevor Daniels wrote: > in that measure. Done. http://codereview.appspot.com/4629073/diff/1003/Documentation/notation/simult... Documentation/notation/simultaneous.itely:956: @code{\partcombine} only knows when a note starts in a @code{Voice}, it On 2011/06/26 22:00:52, Trevor Daniels wrote: > @code{Voice}; Done. http://codereview.appspot.com/4629073/diff/1003/Documentation/notation/simult... Documentation/notation/simultaneous.itely:957: cannot for example, remember if a note in one @code{Voice} has already On 2011/06/26 22:00:52, Trevor Daniels wrote: > cannot, for example, Done.
Sign in to reply to this message.
still looks good; pushing tomorrow am is fine with me.
Sign in to reply to this message.
|
