Issue 4628071: Cleanup: use base/memory/scoped_ptr.h instead of base/scoped_ptr.h.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4628071: Cleanup: use base/memory/scoped_ptr.h instead of base/scoped_ptr.h. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 10 months ago by thestig

Modified:
13 years, 8 months ago

Reviewers:
Roger Tawa, Roger Tawa (Google)

CC:
rlz-codereviews_googlegroups.com

Base URL:
http://rlz.googlecode.com/svn/trunk/

Visibility:
Public.

Cleanup: use base/memory/scoped_ptr.h instead of base/scoped_ptr.h.

Created: 13 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -14 lines)			Patch
M	win/lib/financial_ping.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	win/lib/machine_deal.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	win/lib/process_info.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	win/lib/rlz_lib.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	win/lib/rlz_lib.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	win/lib/rlz_lib_test.cc	View	3 chunks	+2 lines, -3 lines	0 comments	Download

Total messages: 2

Roger Tawa (Google)

13 years, 10 months ago (2011-06-28 20:05:17 UTC) #2

lgtm

I will commit for you shortly.  After I commit, you will need to bump the RLZ
revision in the chrome DEPS file.