Issue 4627085: Create new 'platform' variable to replace use of 'OS' in most places.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4627085: Create new 'platform' variable to replace use of 'OS' in most places. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 6 months ago by epoger

Modified:
13 years, 6 months ago

Reviewers:
caryclark1

CC:
bungeman, yangsu, skia-review_googlegroups.com, bsalomon

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Description

This helps in two ways: - simplifies our conditionals (no more checking for all flavors of unix) - allows us to add new platforms (like building iOS on Mac)

Patch Set 1 #

Patch Set 2 : renamed 'platform' to 'skia_os' #

Created: 13 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+68 lines, -58 lines)			Patch
M	gyp/CocoaDebuggerApp.gyp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	gyp/FileReaderApp.gyp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	gyp/SampleApp.gyp	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	gyp/SimpleCocoaApp.gyp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	gyp/bench.gyp	View	1	3 chunks	+4 lines, -10 lines	0 comments	Download
M	gyp/common.gypi	View	1	4 chunks	+22 lines, -6 lines	0 comments	Download
M	gyp/core.gyp	View	1	4 chunks	+4 lines, -4 lines	0 comments	Download
M	gyp/gpu.gyp	View	1	7 chunks	+15 lines, -15 lines	0 comments	Download
M	gyp/images.gyp	View	1	3 chunks	+5 lines, -5 lines	0 comments	Download
M	gyp/opts.gyp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	gyp/utils.gyp	View	1	6 chunks	+6 lines, -6 lines	0 comments	Download
M	gyp/views.gyp	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	gyp/xml.gyp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	gyp/zlib.gyp	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

committed as r1782

Expand All Messages | Collapse All Messages